[Feature] Allow to lookup Node by its Tailnet IP address in GRPC API #854

Closed
opened 2025-12-29 02:24:53 +01:00 by adam · 4 comments
Owner

Originally created by @jirutka on GitHub (Nov 15, 2024).

Use case

For monitoring purposes, it’s necessary to find out to which node and user a given IP address belongs.

Description

.

Contribution

  • I can write the design doc for this feature
  • I can contribute this feature

How can it be implemented?

a. Change GetNodeRequest to oneof node_id or tailnet_ip. If tailnet_ip is provided, lookup Node by its IPv4 or IPv6 address.
b. Add a new method, e.g. GetNodeByIp.

Originally created by @jirutka on GitHub (Nov 15, 2024). ### Use case For monitoring purposes, it’s necessary to find out to which node and user a given IP address belongs. ### Description . ### Contribution - [ ] I can write the design doc for this feature - [X] I can contribute this feature ### How can it be implemented? a. Change `GetNodeRequest` to `oneof` `node_id` or `tailnet_ip`. If `tailnet_ip` is provided, lookup Node by its IPv4 or IPv6 address. b. Add a new method, e.g. `GetNodeByIp`.
adam added the enhancementstale labels 2025-12-29 02:24:53 +01:00
adam closed this issue 2025-12-29 02:24:53 +01:00
Author
Owner

@kradalby commented on GitHub (Nov 17, 2024):

Sounds reasonable to me, maybe make it reasonable generic and tap into the "list" version so we can do id, name, ip etc?

@kradalby commented on GitHub (Nov 17, 2024): Sounds reasonable to me, maybe make it reasonable generic and tap into the "list" version so we can do id, name, ip etc?
Author
Owner

@kradalby commented on GitHub (Nov 29, 2024):

I started look at this based while working on #2246 and it looks like our usage of the grpc web api generator we use prevents us from using oneof: https://github.com/grpc-ecosystem/grpc-gateway/issues/441

@kradalby commented on GitHub (Nov 29, 2024): I started look at this based while working on #2246 and it looks like our usage of the grpc web api generator we use prevents us from using `oneof`: https://github.com/grpc-ecosystem/grpc-gateway/issues/441
Author
Owner

@github-actions[bot] commented on GitHub (Feb 28, 2025):

This issue is stale because it has been open for 90 days with no activity.

@github-actions[bot] commented on GitHub (Feb 28, 2025): This issue is stale because it has been open for 90 days with no activity.
Author
Owner

@github-actions[bot] commented on GitHub (Mar 7, 2025):

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions[bot] commented on GitHub (Mar 7, 2025): This issue was closed because it has been inactive for 14 days since being marked as stale.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#854