starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[Bug] Does not receive ‘user’ field when changing node owner via API #820

New Issue
Closed
opened 2025-12-29 02:24:26 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:24:26 +01:00
Owner
Copy Link

Originally created by @hopleus on GitHub (Oct 7, 2024).

Is this a support request?

  • This is not a support request

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The passed user field in the v1.MoveNodeRequest (API) request does not come in. Only nodeId is received, because it is passed in url query params

Request payload:

{
"nodeId": 12,
"user": "test"
}

Request in v1.MoveNodeRequest:

{
"nodeId": 12,
"user": ""
}

Current rpc method in headscale.proto

rpc MoveNode(MoveNodeRequest) returns (MoveNodeResponse) {
    option (google.api.http) = {
        post: "/api/v1/node/{node_id}/user"
    };
}

Expected Behavior

The passed user field in the v1.MoveNodeRequest (API) request arrives correctly.

Request payload:

{
"nodeId": 12,
"user": "test"
}

Request in v1.MoveNodeRequest:

{
"nodeId": 12,
"user": "test"
}

Fixed rpc method in headscale.proto

rpc MoveNode(MoveNodeRequest) returns (MoveNodeResponse) {
    option (google.api.http) = {
        post: "/api/v1/node/{node_id}/user",
        body: "*"
    };
}

Steps To Reproduce

  1. Send POST request with valid data to /api/v1/node/{nodeId}/user
  2. Get error user not found

Environment

- OS: MacOS 15
- Headscale version: 0.22.3
- Tailscale version: 1.74.0

Runtime environment

  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

Anything else?

No response

Originally created by @hopleus on GitHub (Oct 7, 2024). ### Is this a support request? - [X] This is not a support request ### Is there an existing issue for this? - [X] I have searched the existing issues ### Current Behavior The passed `user` field in the `v1.MoveNodeRequest` (API) request does not come in. Only nodeId is received, because it is passed in url query params Request payload: ```json { "nodeId": 12, "user": "test" } ``` Request in v1.MoveNodeRequest: ```json { "nodeId": 12, "user": "" } ``` Current rpc method in `headscale.proto` ```proto rpc MoveNode(MoveNodeRequest) returns (MoveNodeResponse) { option (google.api.http) = { post: "/api/v1/node/{node_id}/user" }; } ``` ### Expected Behavior The passed `user` field in the v1.MoveNodeRequest (API) request arrives correctly. Request payload: ```json { "nodeId": 12, "user": "test" } ``` Request in v1.MoveNodeRequest: ```json { "nodeId": 12, "user": "test" } ``` Fixed rpc method in `headscale.proto` ```proto rpc MoveNode(MoveNodeRequest) returns (MoveNodeResponse) { option (google.api.http) = { post: "/api/v1/node/{node_id}/user", body: "*" }; } ``` ### Steps To Reproduce 1. Send POST request with valid data to `/api/v1/node/{nodeId}/user` 2. Get error `user not found` ### Environment ```markdown - OS: MacOS 15 - Headscale version: 0.22.3 - Tailscale version: 1.74.0 ``` ### Runtime environment - [ ] Headscale is behind a (reverse) proxy - [ ] Headscale runs in a container ### Anything else? _No response_
adam added the bug label 2025-12-29 02:24:26 +01:00
adam closed this issue 2025-12-29 02:24:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#820
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?