starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[Bug] Inconsistency ‘givenName’ in node #817

New Issue
Closed
opened 2025-12-29 02:24:23 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:24:23 +01:00
Owner
Copy Link

Originally created by @hopleus on GitHub (Oct 7, 2024).

Is this a support request?

  • This is not a support request

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Host name where the error occurs - MacBook-Pro
(This is the real hostname of my machine)

When registering a node on the network, hostname as well as givenName is stored in its original form from tailcfg.Hostname - MacBook-Pro, without making it based on FQDN rules.
When renaming a node (changing the givenName), the logic checks the new name for FQDN compliance (CheckForFQDNRules) and does not allow the MacBook-Pro name to be saved, requiring lowercase i.e. macbook-pro.

Expected Behavior

When a node is registered on the network, the givenName is stored subject to FQDN rules.

Steps To Reproduce

  1. Register node
  2. Show givenName in DB
  3. Try changing the node name to the same
  4. Receive an FQDN error
  5. Save the new node name taking into account the FQDN rules
  6. It's OK, the new name is saved

Environment

- OS: MacOS 15
- Headscale version: 0.22.3
- Tailscale version: 1.74.0

Runtime environment

  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

Anything else?

No response

Originally created by @hopleus on GitHub (Oct 7, 2024). ### Is this a support request? - [X] This is not a support request ### Is there an existing issue for this? - [X] I have searched the existing issues ### Current Behavior Host name where the error occurs - `MacBook-Pro` **(This is the real hostname of my machine)** When registering a node on the network, `hostname` as well as `givenName` is stored in its original form from `tailcfg.Hostname` - `MacBook-Pro`, without making it based on FQDN rules. When renaming a node (changing the `givenName`), the logic checks the new name for FQDN compliance (`CheckForFQDNRules`) and does not allow the `MacBook-Pro` name to be saved, requiring lowercase i.e. `macbook-pro`. ### Expected Behavior When a node is registered on the network, the givenName is stored subject to FQDN rules. ### Steps To Reproduce 1. Register node 2. Show givenName in DB 3. Try changing the node name to the same 4. Receive an FQDN error 5. Save the new node name taking into account the FQDN rules 6. It's OK, the new name is saved ### Environment ```markdown - OS: MacOS 15 - Headscale version: 0.22.3 - Tailscale version: 1.74.0 ``` ### Runtime environment - [ ] Headscale is behind a (reverse) proxy - [ ] Headscale runs in a container ### Anything else? _No response_
adam added the bug label 2025-12-29 02:24:23 +01:00
adam closed this issue 2025-12-29 02:24:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#817
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?