starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[Bug] Debian packages use incorrect shell #794

New Issue
Closed
opened 2025-12-29 02:24:06 +01:00 by adam · 1 comment
adam commented 2025-12-29 02:24:06 +01:00
Owner
Copy Link

Originally created by @jyundt on GitHub (Sep 14, 2024).

Is this a support request?

  • This is not a support request

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently, the .deb packages create the headscale user with /bin/sh:

fe68f50328/docs/packaging/postinstall.sh (L32)

However, the docs list using /usr/sbin/nologin: fe68f50328/docs/running-headscale-linux-manual.md (L44)

Expected Behavior

Create the headscale user with a default shell of /usr/sbin/nologin. I believe this also generally aligns with standard best practices as well.

Steps To Reproduce

  1. Install headscale .deb
  2. verify headscale shell

Environment

- OS:Ubuntu 22.04.4
- Headscale version: 0.23.0-rc.1
- Tailscale version: N/A

Runtime environment

  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

Anything else?

No response

Originally created by @jyundt on GitHub (Sep 14, 2024). ### Is this a support request? - [X] This is not a support request ### Is there an existing issue for this? - [X] I have searched the existing issues ### Current Behavior Currently, the .deb packages create the `headscale` user with `/bin/sh`: https://github.com/juanfont/headscale/blob/fe68f503289db6cb1c2a568b8ae02a45ac632dd6/docs/packaging/postinstall.sh#L32 However, the docs list using `/usr/sbin/nologin`: https://github.com/juanfont/headscale/blob/fe68f503289db6cb1c2a568b8ae02a45ac632dd6/docs/running-headscale-linux-manual.md?plain=1#L44 ### Expected Behavior Create the `headscale` user with a default shell of `/usr/sbin/nologin`. I believe this also generally aligns with standard best practices as well. ### Steps To Reproduce 1. Install `headscale` .deb 2. verify `headscale` shell ### Environment ```markdown - OS:Ubuntu 22.04.4 - Headscale version: 0.23.0-rc.1 - Tailscale version: N/A ``` ### Runtime environment - [ ] Headscale is behind a (reverse) proxy - [ ] Headscale runs in a container ### Anything else? _No response_
adam added the bug label 2025-12-29 02:24:06 +01:00
adam closed this issue 2025-12-29 02:24:06 +01:00
adam commented 2025-12-29 02:24:07 +01:00
Author
Owner
Copy Link

@jyundt commented on GitHub (Sep 14, 2024):

Quick update: I noticed that the headscale homedir wasn't set correctly either. I included that in my PR: https://github.com/juanfont/headscale/pull/2134

@jyundt commented on GitHub (Sep 14, 2024): Quick update: I noticed that the `headscale` homedir wasn't set correctly either. I included that in my PR: https://github.com/juanfont/headscale/pull/2134
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#794
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?