starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Stricter linting #73

New Issue
Closed
opened 2025-12-29 01:21:43 +01:00 by adam · 1 comment
adam commented 2025-12-29 01:21:43 +01:00
Owner
Copy Link

Originally created by @kradalby on GitHub (Nov 12, 2021).

Originally assigned to: @kradalby on GitHub.

We currently have linting from golangci-lint standard package and some buf linting for proto.

We should add a configuration and consistent ci for linting that covers:

For go:

  • catch bugs
  • Best practices
  • Style

For yaml, markdown and more:

  • formatting with prettier
  • yamllint

For proto:

  • buf linting
  • Clangformatting

All the linters and formatters should be guarded by CI and be trivial for the user to run via make.

Originally created by @kradalby on GitHub (Nov 12, 2021). Originally assigned to: @kradalby on GitHub. We currently have linting from `golangci-lint` standard package and some `buf` linting for proto. We should add a configuration and consistent ci for linting that covers: For go: - catch bugs - Best practices - Style For yaml, markdown and more: - formatting with `prettier` - yamllint For proto: - buf linting - Clangformatting All the linters and formatters should be guarded by CI and be trivial for the user to run via make.
adam added the enhancement label 2025-12-29 01:21:43 +01:00
adam closed this issue 2025-12-29 01:21:43 +01:00
adam commented 2025-12-29 01:21:44 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Nov 12, 2021):

I am to get this in after #212 is merged, if we do this with too much stuff open, we will have a lot of merge conflicts.

@kradalby commented on GitHub (Nov 12, 2021): I am to get this in after #212 is merged, if we do this with too much stuff open, we will have a lot of merge conflicts.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#73
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?