starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Headscale logs in user A with user B's auth key #696

New Issue
Closed
opened 2025-12-29 02:22:11 +01:00 by adam · 2 comments
adam commented 2025-12-29 02:22:11 +01:00
Owner
Copy Link

Originally created by @fredrikekre on GitHub (Apr 17, 2024).

Bug description

Logging in a node with a preauthkey logs in as the previous user that was logged in on the same node, i.e. after performing the following three steps on the same node:

  1. Login with user A's key
  2. Logout A
  3. Login with user B's key

the result is that user A is logged in even though user B's key is used. See full terminal session with the steps to reproduce below. I noticed this with release 0.22.3 when changing the user for some nodes and although the new key was used the same old user was still logged in. The MWE below is with v0.23.0-alpha7.

Environment

  • OS: Ubuntu 22.04
  • Headscale version: v0.23.0-alpha7
  • Tailscale version: 1.64.0

To Reproduce

Install headscale on a clean machine (i.e. no existing config or database)

$ sudo apt install ./headscale_0.23.0-alpha7_linux_amd64.deb
[...]

$ sudo systemctl enable headscale

$ sudo systemctl start headscale

Create users foo and bar with associated keys:

$ sudo headscale users create foo

$ sudo headscale users create bar

$ sudo headscale preauthkeys create --user foo --reusable
73c546e371611141ef442e7aeaff918734708124072d530f

$ sudo headscale preauthkeys create --user bar --reusable
6b00073a57c0828e2cb5dcb4c64e2eef6de0972507f6478c

Login using foo's key works as expected:

$ sudo tailscale up --reset --login-server=http://localhost:8080 --auth-key=73c546e371611141ef442e7aeaff918734708124072d530f

$ tailscale status
100.64.0.1      myhost               foo          linux   -

$ sudo headscale nodes list
ID | Hostname | Name   | MachineKey | NodeKey | User | IP addresses                  | Ephemeral | Last seen           | Expiration          | Connected | Expired
1  | myhost   | myhost | [Rl+ED]    | [YHvFJ] | foo  | 100.64.0.1, fd7a:115c:a1e0::1 | false     | 2024-04-17 14:09:32 | 0001-01-01 00:00:00 | online    | no

Logout foo and login with bar's key:

$ sudo tailscale logout

$ sudo tailscale up --reset --login-server=http://localhost:8080 --auth-key=6b00073a57c0828e2cb5dcb4c64e2eef6de0972507f6478c

Even though the key belongs to bar we are logged in as foo according to both client and server:

$ tailscale status
100.64.0.1      myhost               foo          linux   -

$ sudo headscale nodes list
ID | Hostname | Name   | MachineKey | NodeKey | User | IP addresses                  | Ephemeral | Last seen           | Expiration          | Connected | Expired
1  | myhost   | myhost | [Rl+ED]    | [UgilM] | foo  | 100.64.0.1, fd7a:115c:a1e0::1 | false     | 2024-04-17 14:10:17 | 0001-01-01 00:00:00 | online    | no

Both keys are marked as used:

$ sudo headscale preauthkeys list -u foo
ID | Key                                              | Reusable | Ephemeral | Used | Expiration          | Created             | Tags
1  | 73c546e371611141ef442e7aeaff918734708124072d530f | true     | false     | true | 2024-04-17 15:07:54 | 2024-04-17 14:07:54 |

$ sudo headscale preauthkeys list -u bar
ID | Key                                              | Reusable | Ephemeral | Used | Expiration          | Created             | Tags
2  | 6b00073a57c0828e2cb5dcb4c64e2eef6de0972507f6478c | true     | false     | true | 2024-04-17 15:07:58 | 2024-04-17 14:07:58 |

Logs and attachments

  • ACL configuration: N/A
  • Headscale configuration: Default /etc/headscale/config.yml installed with .deb.
Originally created by @fredrikekre on GitHub (Apr 17, 2024). ## Bug description Logging in a node with a preauthkey logs in as the previous user that was logged in on the same node, i.e. after performing the following three steps on the same node: 1. Login with user A's key 2. Logout A 3. Login with user B's key the result is that user _A_ is logged in even though user _B_'s key is used. See full terminal session with the steps to reproduce below. I noticed this with release 0.22.3 when changing the user for some nodes and although the new key was used the same old user was still logged in. The MWE below is with v0.23.0-alpha7. ## Environment - OS: Ubuntu 22.04 - Headscale version: v0.23.0-alpha7 - Tailscale version: 1.64.0 ## To Reproduce Install headscale on a clean machine (i.e. no existing config or database) ``` $ sudo apt install ./headscale_0.23.0-alpha7_linux_amd64.deb [...] $ sudo systemctl enable headscale $ sudo systemctl start headscale ``` Create users `foo` and `bar` with associated keys: ``` $ sudo headscale users create foo $ sudo headscale users create bar $ sudo headscale preauthkeys create --user foo --reusable 73c546e371611141ef442e7aeaff918734708124072d530f $ sudo headscale preauthkeys create --user bar --reusable 6b00073a57c0828e2cb5dcb4c64e2eef6de0972507f6478c ``` Login using `foo`'s key works as expected: ``` $ sudo tailscale up --reset --login-server=http://localhost:8080 --auth-key=73c546e371611141ef442e7aeaff918734708124072d530f $ tailscale status 100.64.0.1 myhost foo linux - $ sudo headscale nodes list ID | Hostname | Name | MachineKey | NodeKey | User | IP addresses | Ephemeral | Last seen | Expiration | Connected | Expired 1 | myhost | myhost | [Rl+ED] | [YHvFJ] | foo | 100.64.0.1, fd7a:115c:a1e0::1 | false | 2024-04-17 14:09:32 | 0001-01-01 00:00:00 | online | no ``` Logout `foo` and login with `bar`'s key: ``` $ sudo tailscale logout $ sudo tailscale up --reset --login-server=http://localhost:8080 --auth-key=6b00073a57c0828e2cb5dcb4c64e2eef6de0972507f6478c ``` Even though the key belongs to `bar` we are logged in as `foo` according to both client and server: ``` $ tailscale status 100.64.0.1 myhost foo linux - $ sudo headscale nodes list ID | Hostname | Name | MachineKey | NodeKey | User | IP addresses | Ephemeral | Last seen | Expiration | Connected | Expired 1 | myhost | myhost | [Rl+ED] | [UgilM] | foo | 100.64.0.1, fd7a:115c:a1e0::1 | false | 2024-04-17 14:10:17 | 0001-01-01 00:00:00 | online | no ``` Both keys are marked as used: ``` $ sudo headscale preauthkeys list -u foo ID | Key | Reusable | Ephemeral | Used | Expiration | Created | Tags 1 | 73c546e371611141ef442e7aeaff918734708124072d530f | true | false | true | 2024-04-17 15:07:54 | 2024-04-17 14:07:54 | $ sudo headscale preauthkeys list -u bar ID | Key | Reusable | Ephemeral | Used | Expiration | Created | Tags 2 | 6b00073a57c0828e2cb5dcb4c64e2eef6de0972507f6478c | true | false | true | 2024-04-17 15:07:58 | 2024-04-17 14:07:58 | ``` ## Logs and attachments - ACL configuration: N/A - Headscale configuration: Default `/etc/headscale/config.yml` installed with .deb.
adam added the bug label 2025-12-29 02:22:11 +01:00
adam closed this issue 2025-12-29 02:22:11 +01:00
adam commented 2025-12-29 02:22:13 +01:00
Author
Owner
Copy Link

@fredrikekre commented on GitHub (May 2, 2024):

Thanks for the fix!

@fredrikekre commented on GitHub (May 2, 2024): Thanks for the fix!
adam commented 2025-12-29 02:22:17 +01:00
Author
Owner
Copy Link

@ItsShadowCone commented on GitHub (May 5, 2024):

Is this possibly a dupe previously reported in #1310? Does the fix affect both?

@ItsShadowCone commented on GitHub (May 5, 2024): Is this possibly a dupe previously reported in #1310? Does the fix affect both?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#696
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?