starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Rework IP fields in database #672

New Issue
Closed
opened 2025-12-29 02:21:52 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:21:52 +01:00
Owner
Copy Link

Originally created by @kradalby on GitHub (Mar 14, 2024).

This issue describes a long standing frustration, and is associated with a couple of other issues that will be breaking and used to be harder to solve. Since we break a bunch of stuff for 0.23.0, let us break some more.

Currently we store IPs in a very hacky list in the database from way back and issue https://github.com/juanfont/headscale/issues/295 was created, one of the reasons is that we allowed for multiple prefixes to be defined (so multiple ipv4 or ipv6). These didnt really have an effect and we have now changed this to only allow one of each:

prefixes:
  v6: fd7a:115c:a1e0::/48
  v4: 100.64.0.0/10

Naturally, this means that machines will get one of each address, and this allows us to simplify the model for this in the database. Instead of having one list, we can have two colums: v4 and v6, containing the ip of the machine, and logic that automatically pulls it out as a netip.Addr. This will make the developer ergonomics a lot neater and simpler.

This simplification, with the help of the new IP allocator (https://github.com/juanfont/headscale/pull/1756) should allow us to more easily fix a bunch of outstanding (and longstanding) issues:

The migration logic can be a bit hairy, what if some people, somehow has multiple addrs of the same family in the list in the database?

Originally created by @kradalby on GitHub (Mar 14, 2024). This issue describes a long standing frustration, and is associated with a couple of other issues that will be breaking and used to be harder to solve. Since we break a bunch of stuff for 0.23.0, let us break some more. Currently we store IPs in a very hacky list in the database from way back and issue https://github.com/juanfont/headscale/issues/295 was created, one of the reasons is that we allowed for multiple prefixes to be defined (so multiple ipv4 or ipv6). These didnt really have an effect and we have now changed this to only allow one of each: ```yaml prefixes: v6: fd7a:115c:a1e0::/48 v4: 100.64.0.0/10 ``` Naturally, this means that machines will get one of each address, and this allows us to simplify the model for this in the database. Instead of having one list, we can have two colums: `v4` and `v6`, containing the ip of the machine, and logic that automatically pulls it out as a `netip.Addr`. This will make the developer ergonomics a lot neater and simpler. This simplification, with the help of the new IP allocator (https://github.com/juanfont/headscale/pull/1756) should allow us to more easily fix a bunch of outstanding (and longstanding) issues: - https://github.com/juanfont/headscale/issues/1785 (IPv6 support was accidentally made mandatory) - https://github.com/juanfont/headscale/issues/1827 (Turn off IPv6, we should allow only one, either v4, v6 or both to be set) - https://github.com/juanfont/headscale/issues/614 (If you regret that decision, addrs should be added if a new range is available) - https://github.com/juanfont/headscale/issues/968 (Bonus, allow random, not sequential IP assignment, should be easier with the new allocator) The migration logic can be a bit hairy, what if some people, somehow has multiple addrs of the same family in the list in the database?
adam added the enhancementbug labels 2025-12-29 02:21:52 +01:00
adam closed this issue 2025-12-29 02:21:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#672
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?