starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Orphaned routes accumulating in the routes table #521

New Issue
Closed
opened 2025-12-29 02:19:29 +01:00 by adam · 3 comments
adam commented 2025-12-29 02:19:29 +01:00
Owner
Copy Link

Originally created by @vsychov on GitHub (May 29, 2023).

Originally assigned to: @juanfont on GitHub.

Bug description

Hello,

I'm using headscale with autoApprovers ACL and dynamic Tailscale subnet routers which frequently change their advertised routes. To handle traffic redirection to certain domain names with dynamic DNS, I've set up a script that monitors DNS changes and restarts Tailscale, adjusting the advertise-routes flag according to the resolved DNS. Additionally, the nodes running this setup are ephemeral and periodically replaced. This setup mostly works fine, except for a single issue I've discovered.

The routes table in the database seems to be filling up with entries for routes that are no longer relevant and have no association with any machines:

SELECT
  count(*)
FROM
  routes
  LEFT JOIN machines ON routes.machine_id = machines.ID 
WHERE
  machines.ID IS NULL

This returns approximately 20k entries that are no longer needed.

I believe this to be a bug, as I would expect the routes table to be cleaned up at some point (perhaps when a node is deleted), or when the updated_at field for a route is more than 24 hours old, and both advertised and enabled fields are set to false.

At present, I'm handling the table overflow issue with the following SQL:

DELETE 
FROM
  routes 
WHERE
  "id" IN ( SELECT routes."id" FROM routes LEFT JOIN machines ON routes.machine_id = machines."id" WHERE machines."id" IS NULL ) 
  OR ( updated_at <= ( NOW( ) - INTERVAL '1 DAY' ) AND advertised = 'f' AND enabled = 'f' )

Might it be beneficial to add a goroutine to handle this?
If this change is approved, I would be happy to create a pull request implementing the necessary adjustments.

Thank you for your attention to this matter.

Best regards.

Originally created by @vsychov on GitHub (May 29, 2023). Originally assigned to: @juanfont on GitHub. ## Bug description Hello, I'm using headscale with `autoApprovers` ACL and dynamic Tailscale subnet routers which frequently change their advertised routes. To handle traffic redirection to certain domain names with dynamic DNS, I've set up a script that monitors DNS changes and restarts Tailscale, adjusting the `advertise-routes` flag according to the resolved DNS. Additionally, the nodes running this setup are `ephemeral` and periodically replaced. This setup mostly works fine, except for a single issue I've discovered. The routes table in the database seems to be filling up with entries for routes that are no longer relevant and have no association with any machines: ```sql SELECT count(*) FROM routes LEFT JOIN machines ON routes.machine_id = machines.ID WHERE machines.ID IS NULL ``` This returns approximately 20k entries that are no longer needed. I believe this to be a bug, as I would expect the routes table to be cleaned up at some point (perhaps when a node is deleted), or when the `updated_at` field for a route is more than 24 hours old, and both `advertised` and `enabled` fields are set to `false`. At present, I'm handling the table overflow issue with the following SQL: ```sql DELETE FROM routes WHERE "id" IN ( SELECT routes."id" FROM routes LEFT JOIN machines ON routes.machine_id = machines."id" WHERE machines."id" IS NULL ) OR ( updated_at <= ( NOW( ) - INTERVAL '1 DAY' ) AND advertised = 'f' AND enabled = 'f' ) ``` Might it be beneficial to add a goroutine to handle this? If this change is approved, I would be happy to create a pull request implementing the necessary adjustments. Thank you for your attention to this matter. Best regards.
adam added the stalebug labels 2025-12-29 02:19:29 +01:00
adam closed this issue 2025-12-29 02:19:29 +01:00
adam commented 2025-12-29 02:19:30 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Dec 14, 2023):

This issue is stale because it has been open for 90 days with no activity.

@github-actions[bot] commented on GitHub (Dec 14, 2023): This issue is stale because it has been open for 90 days with no activity.
adam commented 2025-12-29 02:19:30 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Mar 14, 2024):

This issue is stale because it has been open for 90 days with no activity.

@github-actions[bot] commented on GitHub (Mar 14, 2024): This issue is stale because it has been open for 90 days with no activity.
adam commented 2025-12-29 02:19:31 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Mar 21, 2024):

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions[bot] commented on GitHub (Mar 21, 2024): This issue was closed because it has been inactive for 14 days since being marked as stale.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug stale
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#521
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?