starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Bug: peers not notified of deletion when 2 nodes in network #488

New Issue
Closed
opened 2025-12-29 02:18:59 +01:00 by adam · 2 comments
adam commented 2025-12-29 02:18:59 +01:00
Owner
Copy Link

Originally created by @kev-the-dev on GitHub (Apr 27, 2023).

Bug description

  • There are two nodes in a tailnet, A and B
  • Node B is deleted
  • A MapResponse is generated for node A. Node A no longer has any peers, so len(MapResponse.Peers) == 0
  • Tailscale interprets len(MapResponse.Peers) == 0 as no change, meaning it isn't notified of node B being deleted 43819309e1/control/controlclient/map.go (L227)
  • Node B remains on tailnet after being deleted, causing a security vulnerability for deleted nodes

Should be fixed by implementing Peer list deltas (sending PeersDeleted explitcly in #1383)

Originally created by @kev-the-dev on GitHub (Apr 27, 2023). **Bug description** * There are two nodes in a tailnet, A and B * Node B is deleted * A MapResponse is generated for node A. Node A no longer has any peers, so len(MapResponse.Peers) == 0 * Tailscale interprets len(MapResponse.Peers) == 0 as no change, meaning it isn't notified of node B being deleted https://github.com/tailscale/tailscale/blob/43819309e18ac7d496643fcd86489a2ee0927964/control/controlclient/map.go#L227 * Node B remains on tailnet after being deleted, causing a security vulnerability for deleted nodes Should be fixed by implementing Peer list deltas (sending PeersDeleted explitcly in #1383)
adam added the bug label 2025-12-29 02:18:59 +01:00
adam closed this issue 2025-12-29 02:18:59 +01:00
adam commented 2025-12-29 02:18:59 +01:00
Author
Owner
Copy Link

@loprima-l commented on GitHub (Apr 28, 2023):

Hi, can you please close this issue as we have #1383, it will help to see easily what are the urgent fix.

Thanks

@loprima-l commented on GitHub (Apr 28, 2023): Hi, can you please close this issue as we have #1383, it will help to see easily what are the urgent fix. Thanks
adam commented 2025-12-29 02:19:00 +01:00
Author
Owner
Copy Link

@kev-the-dev commented on GitHub (Apr 28, 2023):

dup #1383

@kev-the-dev commented on GitHub (Apr 28, 2023): dup #1383
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#488
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?