starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Potential channel leak #325

New Issue
Closed
opened 2025-12-29 01:27:04 +01:00 by adam · 2 comments
adam commented 2025-12-29 01:27:04 +01:00
Owner
Copy Link

Originally created by @awsong on GitHub (Sep 15, 2022).

Bug description

https://github.com/juanfont/headscale/blob/main/protocol_common_poll.go#L169
After this line, the function returns and updateChan will be left open. The closing call is here: https://github.com/juanfont/headscale/blob/main/protocol_common_poll.go#L613 which won't be reached if line 169 returns.

Originally created by @awsong on GitHub (Sep 15, 2022). <!-- Headscale is a multinational community across the globe. Our common language is English. Please consider raising the bug report in this language. --> **Bug description** [https://github.com/juanfont/headscale/blob/main/protocol_common_poll.go#L169 ](url) After this line, the function returns and updateChan will be left open. The closing call is here: [https://github.com/juanfont/headscale/blob/main/protocol_common_poll.go#L613](url) which won't be reached if line 169 returns.
adam added the stalebug labels 2025-12-29 01:27:04 +01:00
adam closed this issue 2025-12-29 01:27:04 +01:00
adam commented 2025-12-29 01:27:04 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Sep 30, 2023):

This issue is stale because it has been open for 180 days with no activity.

@github-actions[bot] commented on GitHub (Sep 30, 2023): This issue is stale because it has been open for 180 days with no activity.
adam commented 2025-12-29 01:27:05 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Oct 14, 2023):

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions[bot] commented on GitHub (Oct 14, 2023): This issue was closed because it has been inactive for 14 days since being marked as stale.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label bug stale
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#325
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?