starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

Implement long poll for interactive login #306

New Issue
Closed
opened 2025-12-29 01:26:26 +01:00 by adam · 3 comments
adam commented 2025-12-29 01:26:26 +01:00
Owner
Copy Link

Originally created by @juanfont on GitHub (Aug 11, 2022).

When using interactive login (i.e., the web + CLI or OIDC) for client registration, clients expect the control server to enter in a long poll until the client gets registered. This is shown in the mock control server tailscale has for testing https://github.com/tailscale/tailscale/blob/v1.28.0/tstest/integration/testcontrol/testcontrol.go#L451

If this long polling is not followed (or, as we are doing, an immediate response is given), the client will immediately retry... ad infinitum - hammering headscale with requests.

This is what is happening in #603 and #706.

The long-term solution is to implement some basic long poll here, that holds the request until the registration occurs (or the client closed the connection).

Originally created by @juanfont on GitHub (Aug 11, 2022). When using interactive login (i.e., the web + CLI or OIDC) for client registration, clients expect the control server to enter in a long poll until the client gets registered. This is shown in the mock control server tailscale has for testing https://github.com/tailscale/tailscale/blob/v1.28.0/tstest/integration/testcontrol/testcontrol.go#L451 If this long polling is not followed (or, as we are doing, an immediate response is given), the client will immediately retry... _ad infinitum_ - hammering headscale with requests. This is what is happening in #603 and #706. The long-term solution is to implement some basic long poll here, that holds the request until the registration occurs (or the client closed the connection).
adam added the enhancementstale labels 2025-12-29 01:26:26 +01:00
adam closed this issue 2025-12-29 01:26:27 +01:00
adam commented 2025-12-29 01:26:27 +01:00
Author
Owner
Copy Link

@juanfont commented on GitHub (Aug 11, 2022):

I have included a temporary solution in e1e3feb6a8

(should a bit help in #603 and #706)

@juanfont commented on GitHub (Aug 11, 2022): I have included a temporary solution in https://github.com/juanfont/headscale/pull/725/commits/e1e3feb6a810664c43ba5096c476a32a1dcab87c (should a bit help in #603 and #706)
adam commented 2025-12-29 01:26:28 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Oct 2, 2023):

This issue is stale because it has been open for 180 days with no activity.

@github-actions[bot] commented on GitHub (Oct 2, 2023): This issue is stale because it has been open for 180 days with no activity.
adam commented 2025-12-29 01:26:28 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Oct 16, 2023):

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions[bot] commented on GitHub (Oct 16, 2023): This issue was closed because it has been inactive for 14 days since being marked as stale.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label enhancement stale
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?