starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 12:20:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2960] [MERGED] split TestAutoApproveMultiNetwork #2967

New Issue
Closed
opened 2025-12-29 04:19:51 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2960
Author: @kradalby
Created: 12/13/2025
Status: ✅ Merged
Merged: 12/17/2025
Merged by: @kradalby

Base: main ← Head: kradalby/tags-autoapprove

📝 Commits (4)

  • c4b8a73 AGENTS: golangci-lint from main, no "full matrix"
  • 4a5379d integration: prepare AutoApprove test for new tags
  • d8c4e46 .github/workflows: split long TestAutoApproveMultiNetwork into multiple jobs
  • 9e1badf policy: add test to confirm group cant approve tag

📊 Changes

7 files changed (+213 additions, -113 deletions)

View changed files

📝 .github/workflows/gh-action-integration-generator.go (+54 -2)
📝 .github/workflows/integration-test-template.yml (+9 -2)
📝 .github/workflows/test-integration.yaml (+6 -1)
📝 AGENTS.md (+6 -45)
📝 hscontrol/policy/route_approval_test.go (+26 -0)
📝 integration/route_test.go (+95 -58)
📝 integration/scenario.go (+17 -5)

📄 Description

This PR splits the TestAutoApproveMultiNetwork which became way to big for CI. It has convenient names for the go test runner to split partially.

Also add another test to protect against a regression/confirmation that #2891 is implemented correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2960 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 12/13/2025 **Status:** ✅ Merged **Merged:** 12/17/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/tags-autoapprove` --- ### 📝 Commits (4) - [`c4b8a73`](https://github.com/juanfont/headscale/commit/c4b8a739dceebfeef2f80831070dac95a96c5858) AGENTS: golangci-lint from main, no "full matrix" - [`4a5379d`](https://github.com/juanfont/headscale/commit/4a5379d66618e929e9c0cc51ae6a07ae196a1f75) integration: prepare AutoApprove test for new tags - [`d8c4e46`](https://github.com/juanfont/headscale/commit/d8c4e46acebaffc2ce506d5edf3983dccd6598c9) .github/workflows: split long TestAutoApproveMultiNetwork into multiple jobs - [`9e1badf`](https://github.com/juanfont/headscale/commit/9e1badff3bca9e115ec9a63a841aca59dcd776d4) policy: add test to confirm group cant approve tag ### 📊 Changes **7 files changed** (+213 additions, -113 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/gh-action-integration-generator.go` (+54 -2) 📝 `.github/workflows/integration-test-template.yml` (+9 -2) 📝 `.github/workflows/test-integration.yaml` (+6 -1) 📝 `AGENTS.md` (+6 -45) 📝 `hscontrol/policy/route_approval_test.go` (+26 -0) 📝 `integration/route_test.go` (+95 -58) 📝 `integration/scenario.go` (+17 -5) </details> ### 📄 Description This PR splits the TestAutoApproveMultiNetwork which became way to big for CI. It has convenient names for the go test runner to split partially. Also add another test to protect against a regression/confirmation that #2891 is implemented correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:51 +01:00
adam closed this issue 2025-12-29 04:19:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2967
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?