starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2955] [MERGED] types: add option to disable taildrop, improve tests #2962

New Issue
Closed
opened 2025-12-29 04:19:50 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:50 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2955
Author: @kradalby
Created: 12/11/2025
Status: ✅ Merged
Merged: 12/12/2025
Merged by: @kradalby

Base: main ← Head: kradalby/taildrop-tagged

📝 Commits (2)

  • 224487b types: add option to disable taildrop
  • 8b93e86 integration: validate taildrop with tags and multi user

📊 Changes

6 files changed (+356 additions, -85 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 config-example.yaml (+10 -2)
📝 hscontrol/mapper/tail_test.go (+2 -1)
📝 hscontrol/types/config.go (+9 -0)
📝 hscontrol/types/node.go (+6 -3)
📝 integration/general_test.go (+328 -79)

📄 Description

types: add option to disable taildrop

Update TestTaildrop to validate that https://github.com/juanfont/headscale/issues/2462 is fixed
through https://github.com/juanfont/headscale/pull/2885 and https://github.com/juanfont/headscale/pull/2931.

Fixes https://github.com/juanfont/headscale/issues/2462

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2955 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 12/11/2025 **Status:** ✅ Merged **Merged:** 12/12/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/taildrop-tagged` --- ### 📝 Commits (2) - [`224487b`](https://github.com/juanfont/headscale/commit/224487bf5d85d971ae5dc542b0c4d31281ce97cf) types: add option to disable taildrop - [`8b93e86`](https://github.com/juanfont/headscale/commit/8b93e86bec7c705d7192d34011b31db7251ec837) integration: validate taildrop with tags and multi user ### 📊 Changes **6 files changed** (+356 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `config-example.yaml` (+10 -2) 📝 `hscontrol/mapper/tail_test.go` (+2 -1) 📝 `hscontrol/types/config.go` (+9 -0) 📝 `hscontrol/types/node.go` (+6 -3) 📝 `integration/general_test.go` (+328 -79) </details> ### 📄 Description types: add option to disable taildrop Update TestTaildrop to validate that https://github.com/juanfont/headscale/issues/2462 is fixed through https://github.com/juanfont/headscale/pull/2885 and https://github.com/juanfont/headscale/pull/2931. Fixes https://github.com/juanfont/headscale/issues/2462 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:50 +01:00
adam closed this issue 2025-12-29 04:19:50 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2962
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?