starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2942] [CLOSED] feat: implement PingNode gRPC handler #2950

New Issue
Closed
opened 2025-12-29 04:19:47 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:47 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2942
Author: @roganlynch
Created: 12/6/2025
Status: ❌ Closed

Base: main ← Head: pr4b-grpc-impl

📝 Commits (5)

  • 3b8bad4 feat(mapper): add SendDirectUpdate method for direct MapResponse delivery
  • 27e7d10 feat(ping): add core PingRequest/Response implementation
  • e4f6362 Add ping scheduler for node liveness checks
  • 85bab21 Add PingNode RPC protobuf definitions
  • 9d7d05f Implement PingNode gRPC handler

📊 Changes

17 files changed (+1406 additions, -83 deletions)

View changed files

📝 config-example.yaml (+29 -0)
📝 gen/go/headscale/v1/headscale.pb.go (+71 -66)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+81 -0)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+38 -0)
📝 gen/go/headscale/v1/node.pb.go (+179 -12)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+86 -0)
📝 hscontrol/app.go (+15 -0)
📝 hscontrol/grpcv1.go (+83 -5)
📝 hscontrol/mapper/batcher.go (+1 -0)
📝 hscontrol/mapper/batcher_lockfree.go (+32 -0)
📝 hscontrol/noise.go (+75 -0)
➕ hscontrol/ping.go (+280 -0)
➕ hscontrol/ping_scheduler.go (+281 -0)
➕ hscontrol/ping_scheduler_test.go (+111 -0)
📝 hscontrol/types/config.go (+21 -0)
📝 proto/headscale/v1/headscale.proto (+7 -0)
📝 proto/headscale/v1/node.proto (+16 -0)

📄 Description

Implements the PingNode gRPC handler.

Changes

  • PingNode RPC handler: Server-side implementation of the PingNode gRPC method
  • Request validation: Validates node identification and ping parameters
  • PingManager integration: Coordinates with the PingManager to execute pings
  • Response handling: Returns ping results through the gRPC response

Implementation Details

The handler receives PingNode requests through gRPC, validates the request parameters, invokes the PingManager to execute the ping operation, and returns the results. This provides the control plane API for triggering on-demand node pings.

Context

Part of the work discussed in #2902 to add ping functionality to headscale.

Dependencies

  • Requires PR #2941 (protobuf definitions)

Note: This code was generated with assistance from Claude Sonnet 4.5 via cline.bot

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2942 **Author:** [@roganlynch](https://github.com/roganlynch) **Created:** 12/6/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `pr4b-grpc-impl` --- ### 📝 Commits (5) - [`3b8bad4`](https://github.com/juanfont/headscale/commit/3b8bad4252652995d5b95467d39befc79a1a26db) feat(mapper): add SendDirectUpdate method for direct MapResponse delivery - [`27e7d10`](https://github.com/juanfont/headscale/commit/27e7d10285d373c26fc389f20deab4c1458924bb) feat(ping): add core PingRequest/Response implementation - [`e4f6362`](https://github.com/juanfont/headscale/commit/e4f6362853ca2334cc5cec49f32e7d18e3139977) Add ping scheduler for node liveness checks - [`85bab21`](https://github.com/juanfont/headscale/commit/85bab21ba23bee9e4c954cd18f4c2d8c9d51e37e) Add PingNode RPC protobuf definitions - [`9d7d05f`](https://github.com/juanfont/headscale/commit/9d7d05f252ad7266367a0111042ffec8d0e6a76b) Implement PingNode gRPC handler ### 📊 Changes **17 files changed** (+1406 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `config-example.yaml` (+29 -0) 📝 `gen/go/headscale/v1/headscale.pb.go` (+71 -66) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+81 -0) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+38 -0) 📝 `gen/go/headscale/v1/node.pb.go` (+179 -12) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+86 -0) 📝 `hscontrol/app.go` (+15 -0) 📝 `hscontrol/grpcv1.go` (+83 -5) 📝 `hscontrol/mapper/batcher.go` (+1 -0) 📝 `hscontrol/mapper/batcher_lockfree.go` (+32 -0) 📝 `hscontrol/noise.go` (+75 -0) ➕ `hscontrol/ping.go` (+280 -0) ➕ `hscontrol/ping_scheduler.go` (+281 -0) ➕ `hscontrol/ping_scheduler_test.go` (+111 -0) 📝 `hscontrol/types/config.go` (+21 -0) 📝 `proto/headscale/v1/headscale.proto` (+7 -0) 📝 `proto/headscale/v1/node.proto` (+16 -0) </details> ### 📄 Description Implements the PingNode gRPC handler. ## Changes - **PingNode RPC handler**: Server-side implementation of the PingNode gRPC method - **Request validation**: Validates node identification and ping parameters - **PingManager integration**: Coordinates with the PingManager to execute pings - **Response handling**: Returns ping results through the gRPC response ## Implementation Details The handler receives PingNode requests through gRPC, validates the request parameters, invokes the PingManager to execute the ping operation, and returns the results. This provides the control plane API for triggering on-demand node pings. ## Context Part of the work discussed in #2902 to add ping functionality to headscale. ## Dependencies - Requires PR #2941 (protobuf definitions) --- *Note: This code was generated with assistance from Claude Sonnet 4.5 via cline.bot* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:47 +01:00
adam closed this issue 2025-12-29 04:19:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2950
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?