starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2937] feat: minimal Docker Desktop fix - API version 1.44 #2945

New Issue
Open
opened 2025-12-29 04:19:46 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:46 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2937
Author: @roganlynch
Created: 12/6/2025
Status: 🔄 Open

Base: main ← Head: pr1-hi-docker-fixes

📝 Commits (3)

  • 8a627e8 feat: minimal Docker Desktop fix - API version 1.44
  • aac1cc8 feat: implement dynamic Docker API version negotiation
  • 3716226 revert: remove .dockerignore changes to avoid side effects

📊 Changes

1 file changed (+47 additions, -1 deletions)

View changed files

📝 integration/scenario.go (+47 -1)

📄 Description

Fixes Docker Desktop compatibility by updating the minimum API version requirement.

Changes

  • Updates Docker API version check to support version 1.44
  • Enables headscale to work with newer Docker Desktop versions

Context

This change ensures headscale can run properly with recent Docker Desktop installations that use API version 1.44. This is part of the work discussed in #2902 to add ping functionality to headscale.

Note: This code was generated with assistance from Claude Sonnet 4.5 via cline.bot

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2937 **Author:** [@roganlynch](https://github.com/roganlynch) **Created:** 12/6/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `pr1-hi-docker-fixes` --- ### 📝 Commits (3) - [`8a627e8`](https://github.com/juanfont/headscale/commit/8a627e82e66ba3e3ea1ff1676f85204f09e14d08) feat: minimal Docker Desktop fix - API version 1.44 - [`aac1cc8`](https://github.com/juanfont/headscale/commit/aac1cc87bedd6f0e92aaa763ebb49ee92e623478) feat: implement dynamic Docker API version negotiation - [`3716226`](https://github.com/juanfont/headscale/commit/37162267d9c0e1cb08e748a105c2c9e002ac8541) revert: remove .dockerignore changes to avoid side effects ### 📊 Changes **1 file changed** (+47 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `integration/scenario.go` (+47 -1) </details> ### 📄 Description Fixes Docker Desktop compatibility by updating the minimum API version requirement. ## Changes - Updates Docker API version check to support version 1.44 - Enables headscale to work with newer Docker Desktop versions ## Context This change ensures headscale can run properly with recent Docker Desktop installations that use API version 1.44. This is part of the work discussed in #2902 to add ping functionality to headscale. --- *Note: This code was generated with assistance from Claude Sonnet 4.5 via cline.bot* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:46 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2945
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?