starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2930] [MERGED] policy: allow tags to own tags #2940

New Issue
Closed
opened 2025-12-29 04:19:45 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:45 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2930
Author: @kradalby
Created: 12/3/2025
Status: ✅ Merged
Merged: 12/6/2025
Merged by: @kradalby

Base: main ← Head: kradalby/tags-in-tags

📝 Commits (4)

  • fde5327 auth: fix test with wrong type
  • 6cebddb policy: allow tags to own tags
  • 4105114 changelog: add entry
  • 4420935 policy: validate tag relations

📊 Changes

5 files changed (+404 additions, -32 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 hscontrol/auth_test.go (+1 -1)
📝 hscontrol/policy/v2/policy_test.go (+12 -12)
📝 hscontrol/policy/v2/types.go (+124 -8)
📝 hscontrol/policy/v2/types_test.go (+266 -11)

📄 Description

As per Tailscale's implementations, Tags are allowed to
own other tags.

Closes https://github.com/juanfont/headscale/issues/2866

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2930 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 12/3/2025 **Status:** ✅ Merged **Merged:** 12/6/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/tags-in-tags` --- ### 📝 Commits (4) - [`fde5327`](https://github.com/juanfont/headscale/commit/fde53278e8b257022a6b856b88d0334be0fbfea0) auth: fix test with wrong type - [`6cebddb`](https://github.com/juanfont/headscale/commit/6cebddb1e758dffdf564ef3b0ba5ed2e7f12a80f) policy: allow tags to own tags - [`4105114`](https://github.com/juanfont/headscale/commit/4105114fa01476270eb8ce3dd20ee0e772448aef) changelog: add entry - [`4420935`](https://github.com/juanfont/headscale/commit/4420935a96f95f7da708c4eb9250b3fdee25d893) policy: validate tag relations ### 📊 Changes **5 files changed** (+404 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `hscontrol/auth_test.go` (+1 -1) 📝 `hscontrol/policy/v2/policy_test.go` (+12 -12) 📝 `hscontrol/policy/v2/types.go` (+124 -8) 📝 `hscontrol/policy/v2/types_test.go` (+266 -11) </details> ### 📄 Description As per Tailscale's implementations, Tags are allowed to own other tags. Closes https://github.com/juanfont/headscale/issues/2866 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:45 +01:00
adam closed this issue 2025-12-29 04:19:45 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2940
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?