starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2922] [MERGED] cli: remove node move command #2938

New Issue
Closed
opened 2025-12-29 04:19:44 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:44 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2922
Author: @kradalby
Created: 11/28/2025
Status: ✅ Merged
Merged: 12/1/2025
Merged by: @kradalby

Base: main ← Head: kradalby/remove-move

📝 Commits (2)

📊 Changes

14 files changed (+104 additions, -823 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 cmd/headscale/cli/nodes.go (+0 -80)
📝 gen/go/headscale/v1/headscale.pb.go (+66 -71)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+0 -81)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+0 -38)
📝 gen/go/headscale/v1/node.pb.go (+34 -138)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+0 -56)
📝 hscontrol/db/users.go (+0 -20)
📝 hscontrol/db/users_test.go (+0 -109)
📝 hscontrol/grpcv1.go (+0 -16)
📝 hscontrol/state/state.go (+0 -28)
📝 integration/cli_test.go (+0 -172)
📝 proto/headscale/v1/headscale.proto (+0 -7)
📝 proto/headscale/v1/node.proto (+0 -7)

📄 Description

This commit removes support for moving nodes between users.

The reason for this is that allowing such move is going against a intended design about identity in Tailscale, where your peer has an identity based on their machine, and user id. By allowing the node to be moved, we are breaking this contract, a user might have a peer, and it cannot be trusting who owns this peer as it cant change.

This feature should not have been added, and now that Tags are being implemented, essentially representing service account, allowing better seggeration anyways, we will remove it.

One of the problems associated with this would be similar to the email takeover on an OIDC platform.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2922 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/28/2025 **Status:** ✅ Merged **Merged:** 12/1/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/remove-move` --- ### 📝 Commits (2) - [`7c354ca`](https://github.com/juanfont/headscale/commit/7c354caffa0698fe6a357327ec88f258975f5ae2) cli: remove node move command - [`5af6b95`](https://github.com/juanfont/headscale/commit/5af6b95f7990e1ed5493f49b7401b8bb2724b748) changelog: update ### 📊 Changes **14 files changed** (+104 additions, -823 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `cmd/headscale/cli/nodes.go` (+0 -80) 📝 `gen/go/headscale/v1/headscale.pb.go` (+66 -71) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+0 -81) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+0 -38) 📝 `gen/go/headscale/v1/node.pb.go` (+34 -138) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+0 -56) 📝 `hscontrol/db/users.go` (+0 -20) 📝 `hscontrol/db/users_test.go` (+0 -109) 📝 `hscontrol/grpcv1.go` (+0 -16) 📝 `hscontrol/state/state.go` (+0 -28) 📝 `integration/cli_test.go` (+0 -172) 📝 `proto/headscale/v1/headscale.proto` (+0 -7) 📝 `proto/headscale/v1/node.proto` (+0 -7) </details> ### 📄 Description This commit removes support for moving nodes between users. The reason for this is that allowing such move is going against a intended design about identity in Tailscale, where your peer has an identity based on their machine, and user id. By allowing the node to be moved, we are breaking this contract, a user might have a peer, and it cannot be trusting who owns this peer as it cant change. This feature should not have been added, and now that Tags are being implemented, essentially representing service account, allowing better seggeration anyways, we will remove it. One of the problems associated with this would be similar to the email takeover on an OIDC platform. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:44 +01:00
adam closed this issue 2025-12-29 04:19:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2938
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?