starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2885] [MERGED] make tags first class node owner #2918

New Issue
Closed
opened 2025-12-29 04:19:39 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:39 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2885
Author: @kradalby
Created: 11/13/2025
Status: ✅ Merged
Merged: 12/2/2025
Merged by: @kradalby

Base: main ← Head: kradalby/tags-reboot

📝 Commits (6)

  • 96dd104 tags: separate user and tag owned nodes
  • da8f49f poll: simplify logging
  • 467036f lint
  • cec1a2c fixup! tags: separate user and tag owned nodes
  • 1fbf491 fixup! tags: separate user and tag owned nodes
  • c67ca72 .github/workflows: regen

📊 Changes

49 files changed (+3090 additions, -745 deletions)

View changed files

📝 .github/workflows/test-integration.yaml (+2 -1)
📝 AGENTS.md (+336 -0)
📝 CHANGELOG.md (+6 -0)
📝 hscontrol/auth.go (+13 -5)
➕ hscontrol/auth_tags_test.go (+535 -0)
📝 hscontrol/auth_test.go (+83 -58)
📝 hscontrol/db/db.go (+15 -0)
📝 hscontrol/db/db_test.go (+1 -2)
📝 hscontrol/db/ip_test.go (+10 -10)
📝 hscontrol/db/node.go (+19 -9)
📝 hscontrol/db/node_test.go (+22 -29)
📝 hscontrol/db/preauth_keys.go (+44 -16)
📝 hscontrol/db/preauth_keys_test.go (+13 -13)
📝 hscontrol/db/schema.sql (+1 -1)
📝 hscontrol/db/users.go (+5 -1)
📝 hscontrol/db/users_test.go (+3 -3)
📝 hscontrol/grpcv1.go (+30 -3)
📝 hscontrol/grpcv1_test.go (+221 -1)
📝 hscontrol/mapper/mapper.go (+7 -5)
📝 hscontrol/mapper/mapper_test.go (+3 -2)

...and 29 more files

📄 Description

This PR changes tags to be something that exists on nodes in addition to users, to being its own thing. It is part of moving our tags support towards the correct tailscale compatible implementation.

There are probably rough edges in this PR, but the intention is to get it in, and then start fixing bugs from 0.28.0 milestone (long standing tags issue) to discover what works and what doesnt.

Updates #2417
Closes #2619

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2885 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/13/2025 **Status:** ✅ Merged **Merged:** 12/2/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/tags-reboot` --- ### 📝 Commits (6) - [`96dd104`](https://github.com/juanfont/headscale/commit/96dd104d6748e6fc1461c484ac240950f67295cd) tags: separate user and tag owned nodes - [`da8f49f`](https://github.com/juanfont/headscale/commit/da8f49faf158eaee891b7659be9e69b6e84d6034) poll: simplify logging - [`467036f`](https://github.com/juanfont/headscale/commit/467036f866875ca92b386e202bd7f88ebffd6de5) lint - [`cec1a2c`](https://github.com/juanfont/headscale/commit/cec1a2c0e58486552550cde44236668428b3b5ff) fixup! tags: separate user and tag owned nodes - [`1fbf491`](https://github.com/juanfont/headscale/commit/1fbf4915020c7f57b8651f650839f43ae6e55161) fixup! tags: separate user and tag owned nodes - [`c67ca72`](https://github.com/juanfont/headscale/commit/c67ca721c4dd9effb140fbfe72dc918304c9ea38) .github/workflows: regen ### 📊 Changes **49 files changed** (+3090 additions, -745 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration.yaml` (+2 -1) 📝 `AGENTS.md` (+336 -0) 📝 `CHANGELOG.md` (+6 -0) 📝 `hscontrol/auth.go` (+13 -5) ➕ `hscontrol/auth_tags_test.go` (+535 -0) 📝 `hscontrol/auth_test.go` (+83 -58) 📝 `hscontrol/db/db.go` (+15 -0) 📝 `hscontrol/db/db_test.go` (+1 -2) 📝 `hscontrol/db/ip_test.go` (+10 -10) 📝 `hscontrol/db/node.go` (+19 -9) 📝 `hscontrol/db/node_test.go` (+22 -29) 📝 `hscontrol/db/preauth_keys.go` (+44 -16) 📝 `hscontrol/db/preauth_keys_test.go` (+13 -13) 📝 `hscontrol/db/schema.sql` (+1 -1) 📝 `hscontrol/db/users.go` (+5 -1) 📝 `hscontrol/db/users_test.go` (+3 -3) 📝 `hscontrol/grpcv1.go` (+30 -3) 📝 `hscontrol/grpcv1_test.go` (+221 -1) 📝 `hscontrol/mapper/mapper.go` (+7 -5) 📝 `hscontrol/mapper/mapper_test.go` (+3 -2) _...and 29 more files_ </details> ### 📄 Description This PR changes tags to be something that exists on nodes in addition to users, to being its own thing. It is part of moving our tags support towards the correct tailscale compatible implementation. There are probably rough edges in this PR, but the intention is to get it in, and then start fixing bugs from 0.28.0 milestone (long standing tags issue) to discover what works and what doesnt. Updates #2417 Closes #2619 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:39 +01:00
adam closed this issue 2025-12-29 04:19:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2918
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?