starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2873] [MERGED] db: add comment about removing migrations #2908

New Issue
Closed
opened 2025-12-29 04:19:36 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2873
Author: @kradalby
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/10/2025
Merged by: @kradalby

Base: main ← Head: kradalby/migration-depr

📝 Commits (1)

  • 17d93be db: add comment about removing migrations

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 hscontrol/db/db.go (+7 -0)

📄 Description

We want to clean up old migrations (and a lot of testdata) to get rid of old tech debt that has plagued our database for years. With the lift in 0.27.0 to ensure consistency and integrity, this should now be possible.

This PR adds a comment that all migrations above it will be removed in 0.29.0 to allow us to clean up all these things.
Any new migrations in 0.28.0 and 0.29.0 should go below that line and remain.

For the rest of the 0.27.x cycle, we should fix up any late reported integrity issues so we get into a clean state.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2873 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/10/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/migration-depr` --- ### 📝 Commits (1) - [`17d93be`](https://github.com/juanfont/headscale/commit/17d93beeb045d85488c7a6b3dfffe3f823b7d457) db: add comment about removing migrations ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/db/db.go` (+7 -0) </details> ### 📄 Description We want to clean up old migrations (and a lot of testdata) to get rid of old tech debt that has plagued our database for years. With the lift in 0.27.0 to ensure consistency and integrity, this should now be possible. This PR adds a comment that all migrations above it will be removed in 0.29.0 to allow us to clean up all these things. Any new migrations in 0.28.0 and 0.29.0 should go below that line and remain. For the rest of the 0.27.x cycle, we should fix up any late reported integrity issues so we get into a clean state. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:36 +01:00
adam closed this issue 2025-12-29 04:19:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2908
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?