starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2858] [MERGED] Add Favicon to web pages #2901

New Issue
Closed
opened 2025-12-29 04:19:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:35 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2858
Author: @TeejMcSteez
Created: 11/3/2025
Status: ✅ Merged
Merged: 11/12/2025
Merged by: @kradalby

Base: main ← Head: swagger-favicon

📝 Commits (2)

  • ac4e1e3 Added favicon to webpages
  • 85d73e7 Merge branch 'main' into swagger-favicon

📊 Changes

6 files changed (+42 additions, -7 deletions)

View changed files

📝 CHANGELOG.md (+2 -1)
📝 hscontrol/app.go (+2 -2)
➕ hscontrol/assets/favicon.png (+0 -0)
📝 hscontrol/handlers.go (+30 -3)
📝 hscontrol/templates/general.go (+4 -0)
📝 swagger.go (+4 -1)

📄 Description

Fixes Issue #2790

Use's PNG from the GitHub README as a favicon which should be linked to all non-api endpoints. Visiting to / now return's a blank page instead of a 404 and removes the need for the not found function.

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2858 **Author:** [@TeejMcSteez](https://github.com/TeejMcSteez) **Created:** 11/3/2025 **Status:** ✅ Merged **Merged:** 11/12/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `swagger-favicon` --- ### 📝 Commits (2) - [`ac4e1e3`](https://github.com/juanfont/headscale/commit/ac4e1e3ef608cce1018e874da51991cc229815e3) Added favicon to webpages - [`85d73e7`](https://github.com/juanfont/headscale/commit/85d73e71758b9c5722ac5dce73abcf25bc3a7f07) Merge branch 'main' into swagger-favicon ### 📊 Changes **6 files changed** (+42 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -1) 📝 `hscontrol/app.go` (+2 -2) ➕ `hscontrol/assets/favicon.png` (+0 -0) 📝 `hscontrol/handlers.go` (+30 -3) 📝 `hscontrol/templates/general.go` (+4 -0) 📝 `swagger.go` (+4 -1) </details> ### 📄 Description **Fixes Issue #2790** Use's PNG from the GitHub README as a favicon which should be linked to all non-api endpoints. Visiting to `/` now return's a blank page instead of a 404 and removes the need for the not found function. - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [x] updated CHANGELOG.md --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:35 +01:00
adam closed this issue 2025-12-29 04:19:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2901
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?