starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2854] [MERGED] cli: only validate bypass-grpc set policy #2895

New Issue
Closed
opened 2025-12-29 04:19:33 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:33 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2854
Author: @kradalby
Created: 11/1/2025
Status: ✅ Merged
Merged: 11/2/2025
Merged by: @kradalby

Base: main ← Head: kradalby/2825-policy-cli-err

📝 Commits (1)

  • c54e917 cli: only validate bypass-grpc set policy

📊 Changes

1 file changed (+11 additions, -6 deletions)

View changed files

📝 cmd/headscale/cli/policy.go (+11 -6)

📄 Description

When adding the mode to bypass gRPC, a naive policy validation was added to both the gRPC set, and the bypass mode.

This caused the policy to invalidate in unexpected ways as the gRPC already handles this validation in the backend.

This commit moves the validation logic into the bypass branch.

Fixes #2825

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2854 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/1/2025 **Status:** ✅ Merged **Merged:** 11/2/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/2825-policy-cli-err` --- ### 📝 Commits (1) - [`c54e917`](https://github.com/juanfont/headscale/commit/c54e9171cd1774ce80a914001453c62976b6bd58) cli: only validate bypass-grpc set policy ### 📊 Changes **1 file changed** (+11 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/policy.go` (+11 -6) </details> ### 📄 Description When adding the mode to bypass gRPC, a naive policy validation was added to both the gRPC set, and the bypass mode. This caused the policy to invalidate in unexpected ways as the gRPC already handles this validation in the backend. This commit moves the validation logic into the bypass branch. Fixes #2825 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:33 +01:00
adam closed this issue 2025-12-29 04:19:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2895
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?