starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2831] [MERGED] remove unused ips from alloc ipset #2886

New Issue
Closed
opened 2025-12-29 04:19:30 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:30 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2831
Author: @bobelev
Created: 10/28/2025
Status: ✅ Merged
Merged: 11/12/2025
Merged by: @kradalby

Base: main ← Head: bblv/ipset

📝 Commits (2)

  • c800935 fix: free ips from usedIps ipset on DeleteNode
  • 6c98342 changelog: add changelog entry

📊 Changes

3 files changed (+14 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 hscontrol/db/ip.go (+9 -0)
📝 hscontrol/state/state.go (+2 -0)

📄 Description

With IPAllocationStrategy = "random" and strange environments (small VPN CIDR + k8s pods) users can run out of available IPs. So let's remove ips from ipset on DeleteNode.

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2831 **Author:** [@bobelev](https://github.com/bobelev) **Created:** 10/28/2025 **Status:** ✅ Merged **Merged:** 11/12/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `bblv/ipset` --- ### 📝 Commits (2) - [`c800935`](https://github.com/juanfont/headscale/commit/c8009359267f6b11d88fea414b4e1012ab3462da) fix: free ips from usedIps ipset on DeleteNode - [`6c98342`](https://github.com/juanfont/headscale/commit/6c983420032875bf7630931f9640a054e70c0ef2) changelog: add changelog entry ### 📊 Changes **3 files changed** (+14 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `hscontrol/db/ip.go` (+9 -0) 📝 `hscontrol/state/state.go` (+2 -0) </details> ### 📄 Description With IPAllocationStrategy = "random" and strange environments (small VPN CIDR + k8s pods) users can run out of available IPs. So let's remove ips from ipset on DeleteNode. - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:30 +01:00
adam closed this issue 2025-12-29 04:19:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2886
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?