starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2815] [MERGED] integration: reduce TestAutoApproveMultiNetwork matrix to 3 tests #2876

New Issue
Closed
opened 2025-12-29 04:19:28 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:28 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2815
Author: @kradalby
Created: 10/24/2025
Status: ✅ Merged
Merged: 10/27/2025
Merged by: @kradalby

Base: main ← Head: kradalby/reduce-autogrouptest

📝 Commits (2)

  • 4824ce7 integration/hsic: use pidof instead of ps/grep for PID detection
  • 458ea43 integration: reduce TestAutoApproveMultiNetwork matrix to 3 tests

📊 Changes

2 files changed (+38 additions, -15 deletions)

View changed files

📝 integration/hsic/hsic.go (+17 -15)
📝 integration/route_test.go (+21 -0)

📄 Description

Reduces the test matrix from 24 combinations to 3 representative tests
to avoid overwhelming Docker and disk space. The minimal set covers all
key dimensions: both auth methods, all approver types, both policy modes,
and both advertiseDuringUp values.

Set HEADSCALE_INTEGRATION_FULL_MATRIX=1 to run all 24 tests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2815 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 10/27/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/reduce-autogrouptest` --- ### 📝 Commits (2) - [`4824ce7`](https://github.com/juanfont/headscale/commit/4824ce7abcf53d11be7bb729cc3b852bd5210de4) integration/hsic: use pidof instead of ps/grep for PID detection - [`458ea43`](https://github.com/juanfont/headscale/commit/458ea43e6250846f0493fae515955bbc8ed6acc2) integration: reduce TestAutoApproveMultiNetwork matrix to 3 tests ### 📊 Changes **2 files changed** (+38 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `integration/hsic/hsic.go` (+17 -15) 📝 `integration/route_test.go` (+21 -0) </details> ### 📄 Description Reduces the test matrix from 24 combinations to 3 representative tests to avoid overwhelming Docker and disk space. The minimal set covers all key dimensions: both auth methods, all approver types, both policy modes, and both advertiseDuringUp values. Set HEADSCALE_INTEGRATION_FULL_MATRIX=1 to run all 24 tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:28 +01:00
adam closed this issue 2025-12-29 04:19:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?