starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 04:40:29 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2769] [MERGED] app: fix sigint hanging #2849

New Issue
Closed
opened 2025-12-29 04:19:18 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2769
Author: @kradalby
Created: 9/10/2025
Status: ✅ Merged
Merged: 9/11/2025
Merged by: @kradalby

Base: main ← Head: kradalby/2751-sigint

📝 Commits (1)

📊 Changes

4 files changed (+57 additions, -23 deletions)

View changed files

📝 hscontrol/app.go (+11 -10)
📝 hscontrol/mapper/batcher_lockfree.go (+31 -6)
📝 hscontrol/mapper/batcher_test.go (+13 -5)
📝 hscontrol/poll.go (+2 -2)

📄 Description

When the node notifier was replaced with batcher, we removed its closing, but forgot to add the batchers so it was never stopping node connections and waiting forever.

Fixes #2751

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2769 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 9/10/2025 **Status:** ✅ Merged **Merged:** 9/11/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/2751-sigint` --- ### 📝 Commits (1) - [`0aa2c52`](https://github.com/juanfont/headscale/commit/0aa2c52718534345caec722cee76a9edea9eb512) app: fix sigint hanging ### 📊 Changes **4 files changed** (+57 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/app.go` (+11 -10) 📝 `hscontrol/mapper/batcher_lockfree.go` (+31 -6) 📝 `hscontrol/mapper/batcher_test.go` (+13 -5) 📝 `hscontrol/poll.go` (+2 -2) </details> ### 📄 Description When the node notifier was replaced with batcher, we removed its closing, but forgot to add the batchers so it was never stopping node connections and waiting forever. Fixes #2751 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:18 +01:00
adam closed this issue 2025-12-29 04:19:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2849
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?