[PR #2760] [CLOSED] fix: node list-routes output formatting #2841

New Issue

adam · 2025-12-29T04:19:16+01:00

adam commented

2025-12-29 04:19:16 +01:00

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2760
Author: @YouSysAdmin
Created: 9/5/2025
Status: ❌ Closed

Base: main ← Head: fix/routess-list-output

📝 Commits (1)

c38a20a fix: node lisst-routes output format

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 cmd/headscale/cli/nodes.go (+3 -3)

📄 Description

Small fix for node list-routes formatting.

Problem:

If you have many routes for one node, this will result in incorrect output that will be unusable.

ID | Hostname                     | Approved                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    | Available                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   | Serving (Primary)
2  | vpn-router           | 0.0.0.0/0, 234.2.0.0/16, 234.3.0.0/16, 234.4.0.0/16, 234.5.0.0/16, 234.6.0.0/16, 234.7.0.0/16, 234.9.0.0/16, 234.234.0.0/16, 234.12.0.0/16, 234.14.0.0/16, 234.16.0.0/16, 234.17.0.0/16, 234.18.0.0/16, 234.19.0.0/16, 234.21.0.0/16, 234.23.0.0/16, 234.24.0.0/16, 234.25.0.0/16, 234.26.0.0/16, 234.27.0.0/16, 234.28.0.0/16, 234.29.0.0/16, 234.34.0.0/16, 234.35.0.0/16, 234.37.0.0/16, 234.38.0.0/16, 234.40.0.0/16, 234.205.0.0/16, 234.252.16.0/23, 234.31.0.0/24, ....

Fix:

This fix propagates a change to replace the comma-separated list with a list separated by line breaks.
Plus it makes routes analysis much easier.

ID | Hostname     | Approved.       | Available       | Serving (Primary)
2  | vpn-router   | 0.0.0.0/0       | 0.0.0.0/0       | 234.2.0.0/16
   |              | 234.2.0.0/16    | 234.2.0.0/16    | 234.3.0.0/16
   |              | 234.3.0.0/16    | 234.3.0.0/16    | 234.4.0.0/16
   |              | 234.4.0.0/16    | 234.4.0.0/16    | 234.5.0.0/16
   |              | 234.5.0.0/16    | 234.5.0.0/16    | 234.6.0.0/16
   |              | 234.6.0.0/16    | 234.6.0.0/16    | 234.7.0.0/16
   |              | 234.7.0.0/16    | 234.7.0.0/16    | 234.9.0.0/16
   |              | 234.9.0.0/16    | 234.9.0.0/16    | 234.234.0.0/16
   |              | 234.234.0.0/16  | 234.234.0.0/16  | 234.12.0.0/16
   |              | 234.12.0.0/16   | 234.12.0.0/16   | 234.14.0.0/16
   |              | 234.14.0.0/16   | 234.14.0.0/16   | 234.16.0.0/16
   |              | 234.16.0.0/16   | 234.16.0.0/16   | 234.17.0.0/16
   |              | 234.17.0.0/16   | 234.17.0.0/16   | 234.18.0.0/16
   |              | 234.18.0.0/16   | 234.18.0.0/16   | 234.19.0.0/16
   |              | 234.19.0.0/16   | 234.19.0.0/16   | 234.21.0.0/16
   |              | 234.21.0.0/16   | 234.21.0.0/16   | 234.23.0.0/16

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2760 **Author:** [@YouSysAdmin](https://github.com/YouSysAdmin) **Created:** 9/5/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/routess-list-output` --- ### 📝 Commits (1) - [`c38a20a`](https://github.com/juanfont/headscale/commit/c38a20abf855e726d44892f323cd29a9e358a34c) fix: node lisst-routes output format ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `cmd/headscale/cli/nodes.go` (+3 -3) </details> ### 📄 Description Small fix for `node list-routes` formatting. ### Problem: If you have many routes for one node, this will result in incorrect output that will be unusable. ``` ID | Hostname | Approved | Available | Serving (Primary) 2 | vpn-router | 0.0.0.0/0, 234.2.0.0/16, 234.3.0.0/16, 234.4.0.0/16, 234.5.0.0/16, 234.6.0.0/16, 234.7.0.0/16, 234.9.0.0/16, 234.234.0.0/16, 234.12.0.0/16, 234.14.0.0/16, 234.16.0.0/16, 234.17.0.0/16, 234.18.0.0/16, 234.19.0.0/16, 234.21.0.0/16, 234.23.0.0/16, 234.24.0.0/16, 234.25.0.0/16, 234.26.0.0/16, 234.27.0.0/16, 234.28.0.0/16, 234.29.0.0/16, 234.34.0.0/16, 234.35.0.0/16, 234.37.0.0/16, 234.38.0.0/16, 234.40.0.0/16, 234.205.0.0/16, 234.252.16.0/23, 234.31.0.0/24, .... ``` ### Fix: This fix propagates a change to replace the comma-separated list with a list separated by line breaks. Plus it makes routes analysis much easier. ``` ID | Hostname | Approved. | Available | Serving (Primary) 2 | vpn-router | 0.0.0.0/0 | 0.0.0.0/0 | 234.2.0.0/16 | | 234.2.0.0/16 | 234.2.0.0/16 | 234.3.0.0/16 | | 234.3.0.0/16 | 234.3.0.0/16 | 234.4.0.0/16 | | 234.4.0.0/16 | 234.4.0.0/16 | 234.5.0.0/16 | | 234.5.0.0/16 | 234.5.0.0/16 | 234.6.0.0/16 | | 234.6.0.0/16 | 234.6.0.0/16 | 234.7.0.0/16 | | 234.7.0.0/16 | 234.7.0.0/16 | 234.9.0.0/16 | | 234.9.0.0/16 | 234.9.0.0/16 | 234.234.0.0/16 | | 234.234.0.0/16 | 234.234.0.0/16 | 234.12.0.0/16 | | 234.12.0.0/16 | 234.12.0.0/16 | 234.14.0.0/16 | | 234.14.0.0/16 | 234.14.0.0/16 | 234.16.0.0/16 | | 234.16.0.0/16 | 234.16.0.0/16 | 234.17.0.0/16 | | 234.17.0.0/16 | 234.17.0.0/16 | 234.18.0.0/16 | | 234.18.0.0/16 | 234.18.0.0/16 | 234.19.0.0/16 | | 234.19.0.0/16 | 234.19.0.0/16 | 234.21.0.0/16 | | 234.21.0.0/16 | 234.21.0.0/16 | 234.23.0.0/16 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 04:19:16 +01:00

adam closed this issue

2025-12-29 04:19:16 +01:00

Sign in to join this conversation.

Branches Tags

main

update_flake_lock_action

gh-pages

kradalby/release-v0.27.2

dependabot/go_modules/golang.org/x/crypto-0.45.0

dependabot/go_modules/github.com/opencontainers/runc-1.3.3

copilot/investigate-headscale-issue-2788

copilot/investigate-visibility-issue-2788

copilot/investigate-issue-2833

copilot/debug-issue-2846

copilot/fix-issue-2847

dependabot/go_modules/github.com/go-viper/mapstructure/v2-2.4.0

dependabot/go_modules/github.com/docker/docker-28.3.3incompatible

kradalby/cli-experiement3

doc/0.26.1

doc/0.25.1

doc/0.25.0

doc/0.24.3

doc/0.24.2

doc/0.24.1

doc/0.24.0

kradalby/build-docker-on-pr

topic/docu-versioning

topic/docker-kos

juanfont/fix-crash-node-id

juanfont/better-disclaimer

update-contributors

topic/prettier

revert-1893-add-test-stage-to-docs

add-test-stage-to-docs

remove-node-check-interval

fix-empty-prefix

fix-ephemeral-reusable

bug_report-debuginfo

autogroups

logs-to-stderr

revert-1414-topic/fix_unix_socket

rename-machine-node

port-embedded-derp-tests-v2

port-derp-tests

duplicate-word-linter

update-tailscale-1.36

warn-against-apache

ko-fi-link

more-acl-tests

fix-typo-standalone

parallel-nolint

tparallel-fix

rerouting

ssh-changelog-docs

oidc-cleanup

web-auth-flow-tests

kradalby-gh-runner

fix-proto-lint

remove-funding-links

go-1.19

enable-1.30-in-tests

0.16.x

cosmetic-changes-integration

tmp-fix-integration-docker

fix-integration-docker

configurable-update-interval

show-nodes-online

hs2021

acl-syntax-fixes

ts2021-implementation

fix-spurious-updates

unstable-integration-tests

mandatory-stun

embedded-derp

prtemplate-fix

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/headscale#2841