starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2734] [MERGED] Allow all traffic if acls field is omited from the policy #2826

New Issue
Closed
opened 2025-12-29 04:19:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2734
Author: @afonsofrancof
Created: 8/16/2025
Status: ✅ Merged
Merged: 8/18/2025
Merged by: @nblock

Base: main ← Head: empty-acl

📝 Commits (2)

  • 70f8733 fix: allow all traffic if acls field is omited from the policy
  • 0e677b9 docs(acls): Add example for allow/deny all acl policy

📊 Changes

3 files changed (+34 additions, -17 deletions)

View changed files

📝 docs/ref/acls.md (+31 -14)
📝 hscontrol/policy/v2/filter.go (+1 -1)
📝 hscontrol/policy/v2/policy_test.go (+2 -2)

📄 Description

This PR fixes #2672.

It makes headscale follow the following tailscale rules.

image image

In the code this translates to a nil ACLs field in the Policy struct if it doesn't exist in the policy dict (first scenario) , and a non-nil 0-length array in the same field when it exists but is empty (second scenario)

This is nice to have because if you're setting up a file or database policy, you can start with an empty {} as the contents, which means everything is allowed. Then you can add your specific rules later on.

It also prevents people from accidentally locking themselves out of the tailnet when they start experimenting with acls ( happened to me 😅 )

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2734 **Author:** [@afonsofrancof](https://github.com/afonsofrancof) **Created:** 8/16/2025 **Status:** ✅ Merged **Merged:** 8/18/2025 **Merged by:** [@nblock](https://github.com/nblock) **Base:** `main` ← **Head:** `empty-acl` --- ### 📝 Commits (2) - [`70f8733`](https://github.com/juanfont/headscale/commit/70f8733426f8b5272c94c308ed6ae1673fe22e0c) fix: allow all traffic if acls field is omited from the policy - [`0e677b9`](https://github.com/juanfont/headscale/commit/0e677b950721a3e192e948a757dd5ea52f8a433b) docs(acls): Add example for allow/deny all acl policy ### 📊 Changes **3 files changed** (+34 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `docs/ref/acls.md` (+31 -14) 📝 `hscontrol/policy/v2/filter.go` (+1 -1) 📝 `hscontrol/policy/v2/policy_test.go` (+2 -2) </details> ### 📄 Description This PR fixes #2672. It makes headscale follow the following tailscale rules. <img width="1528" height="266" alt="image" src="https://github.com/user-attachments/assets/e5574240-4ca5-44a7-9d2e-3b92ebc5435b" /> <img width="1528" height="380" alt="image" src="https://github.com/user-attachments/assets/7530c13e-6cda-4433-87ba-dd29443aac2d" /> In the code this translates to a `nil` `ACLs` field in the `Policy` struct if it doesn't exist in the policy dict (first scenario) , and a non-nil 0-length array in the same field when it exists but is empty (second scenario) This is nice to have because if you're setting up a file or database policy, you can start with an empty {} as the contents, which means everything is allowed. Then you can add your specific rules later on. It also prevents people from accidentally locking themselves out of the tailnet when they start experimenting with acls ( happened to me 😅 ) - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [x] added unit tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:12 +01:00
adam closed this issue 2025-12-29 04:19:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2826
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?