[PR #2680] [MERGED] integration: replace time.Sleep with assert.EventuallyWithT #2799

Closed
opened 2025-12-29 04:19:01 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2680
Author: @kradalby
Created: 7/9/2025
Status: Merged
Merged: 7/10/2025
Merged by: @kradalby

Base: mainHead: kradalby/assert-eventually


📝 Commits (4)

📊 Changes

73 files changed (+584 additions, -573 deletions)

View changed files

📝 .github/workflows/docs-deploy.yml (+1 -2)
📝 .github/workflows/integration-test-template.yml (+1 -1)
📝 .github/workflows/lint.yml (+2 -4)
📝 cmd/headscale/cli/debug.go (+1 -1)
📝 cmd/headscale/cli/mockoidc.go (+2 -1)
📝 cmd/headscale/cli/nodes.go (+6 -21)
📝 cmd/headscale/cli/users.go (+13 -24)
📝 cmd/hi/cleanup.go (+6 -6)
📝 cmd/hi/docker.go (+21 -20)
📝 cmd/hi/tar_utils.go (+4 -5)
📝 flake.nix (+1 -0)
📝 hscontrol/auth.go (+3 -3)
📝 hscontrol/capver/capver.go (+1 -2)
📝 hscontrol/capver/capver_generated.go (+12 -13)
📝 hscontrol/db/db.go (+3 -2)
📝 hscontrol/derp/server/derp_server.go (+1 -1)
📝 hscontrol/dns/extrarecords.go (+0 -1)
📝 hscontrol/grpcv1.go (+4 -1)
📝 hscontrol/handlers.go (+2 -1)
📝 hscontrol/mapper/mapper.go (+1 -1)

...and 53 more files

📄 Description

A lot of the tests are unstable because timing issues on different type of devices (gh actions vs laptop vs desktop)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2680 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 7/9/2025 **Status:** ✅ Merged **Merged:** 7/10/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/assert-eventually` --- ### 📝 Commits (4) - [`9b47f71`](https://github.com/juanfont/headscale/commit/9b47f71f370088b5119cacf5880a7914b936deeb) integration: replace time.Sleep with Eventually - [`baa4fb9`](https://github.com/juanfont/headscale/commit/baa4fb96159c5de6ed9d9b033831e6f713e44098) fix - [`a304074`](https://github.com/juanfont/headscale/commit/a30407484f5922198cd24034f0cde9de334571fc) fix - [`3a1608e`](https://github.com/juanfont/headscale/commit/3a1608e6f53c9810b55baa83fcdec97f53b67c69) fix ### 📊 Changes **73 files changed** (+584 additions, -573 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/docs-deploy.yml` (+1 -2) 📝 `.github/workflows/integration-test-template.yml` (+1 -1) 📝 `.github/workflows/lint.yml` (+2 -4) 📝 `cmd/headscale/cli/debug.go` (+1 -1) 📝 `cmd/headscale/cli/mockoidc.go` (+2 -1) 📝 `cmd/headscale/cli/nodes.go` (+6 -21) 📝 `cmd/headscale/cli/users.go` (+13 -24) 📝 `cmd/hi/cleanup.go` (+6 -6) 📝 `cmd/hi/docker.go` (+21 -20) 📝 `cmd/hi/tar_utils.go` (+4 -5) 📝 `flake.nix` (+1 -0) 📝 `hscontrol/auth.go` (+3 -3) 📝 `hscontrol/capver/capver.go` (+1 -2) 📝 `hscontrol/capver/capver_generated.go` (+12 -13) 📝 `hscontrol/db/db.go` (+3 -2) 📝 `hscontrol/derp/server/derp_server.go` (+1 -1) 📝 `hscontrol/dns/extrarecords.go` (+0 -1) 📝 `hscontrol/grpcv1.go` (+4 -1) 📝 `hscontrol/handlers.go` (+2 -1) 📝 `hscontrol/mapper/mapper.go` (+1 -1) _...and 53 more files_ </details> ### 📄 Description A lot of the tests are unstable because timing issues on different type of devices (gh actions vs laptop vs desktop) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:01 +01:00
adam closed this issue 2025-12-29 04:19:01 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2799