starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2679] [CLOSED] fix: prevent single node timeout from blocking all other updates #2797

New Issue
Closed
opened 2025-12-29 04:19:01 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2679
Author: @bobelev
Created: 7/9/2025
Status: ❌ Closed

Base: main ← Head: bblv/next

📝 Commits (1)

  • 2e8472a fix: prevent single node timeout from blocking all other updates

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 hscontrol/notifier/notifier.go (+1 -1)

📄 Description

One blocked/slow node in sendAll() was causing early return, skipping
all remaining nodes in iteration. Change return to continue to ensure
all healthy nodes receive updates even when some fail.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2679 **Author:** [@bobelev](https://github.com/bobelev) **Created:** 7/9/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bblv/next` --- ### 📝 Commits (1) - [`2e8472a`](https://github.com/juanfont/headscale/commit/2e8472a31d0c5ad2b4630036dfbc22b47425481c) fix: prevent single node timeout from blocking all other updates ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/notifier/notifier.go` (+1 -1) </details> ### 📄 Description One blocked/slow node in sendAll() was causing early return, skipping all remaining nodes in iteration. Change return to continue to ensure all healthy nodes receive updates even when some fail. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:01 +01:00
adam closed this issue 2025-12-29 04:19:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2797
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?