starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2677] [MERGED] Fix HA subnet routers from #2639 #2796

New Issue
Closed
opened 2025-12-29 04:19:01 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:19:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2677
Author: @kradalby
Created: 7/8/2025
Status: ✅ Merged
Merged: 7/8/2025
Merged by: @kradalby

Base: main ← Head: kradalby/ha-failover-broken

📝 Commits (1)

  • 8f53dd2 poll: use nodeview everywhere

📊 Changes

4 files changed (+178 additions, -119 deletions)

View changed files

📝 hscontrol/auth.go (+6 -0)
📝 hscontrol/noise.go (+10 -10)
📝 hscontrol/poll.go (+129 -99)
📝 hscontrol/state/state.go (+33 -10)

📄 Description

#2639 broke HA by not setting routes in the same way when nodes come and go, this fixes it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2677 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 7/8/2025 **Status:** ✅ Merged **Merged:** 7/8/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/ha-failover-broken` --- ### 📝 Commits (1) - [`8f53dd2`](https://github.com/juanfont/headscale/commit/8f53dd2d2a0defb8e83022252203fd29f85c71eb) poll: use nodeview everywhere ### 📊 Changes **4 files changed** (+178 additions, -119 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/auth.go` (+6 -0) 📝 `hscontrol/noise.go` (+10 -10) 📝 `hscontrol/poll.go` (+129 -99) 📝 `hscontrol/state/state.go` (+33 -10) </details> ### 📄 Description #2639 broke HA by not setting routes in the same way when nodes come and go, this fixes it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:19:01 +01:00
adam closed this issue 2025-12-29 04:19:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2796
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?