starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2653] [MERGED] hscontrol: remove go-grpc-middleware v1 dependency #2783

New Issue
Closed
opened 2025-12-29 04:18:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:18:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2653
Author: @kradalby
Created: 6/23/2025
Status: ✅ Merged
Merged: 6/23/2025
Merged by: @kradalby

Base: main ← Head: kradalby/grpc-gateway-upgrade

📝 Commits (1)

  • da24961 hscontrol: remove go-grpc-middleware v1 dependency

📊 Changes

5 files changed (+10 additions, -76 deletions)

View changed files

📝 flake.nix (+1 -1)
📝 go.mod (+0 -1)
📝 go.sum (+0 -65)
📝 hscontrol/app.go (+4 -7)
📝 proto/buf.lock (+5 -2)

📄 Description

Replace grpc-ecosystem/go-grpc-middleware v1.4.0 with gRPC's built-in interceptor chaining. The v1 library's ChainUnaryServer function is deprecated as gRPC now provides native chaining via grpc.ChainUnaryInterceptor.

Also update protobuf dependencies in buf.lock:

  • googleapis: 62f35d8a -> 61b203b9
  • grpc-gateway: bc28b723 -> 4c5ba75c

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2653 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 6/23/2025 **Status:** ✅ Merged **Merged:** 6/23/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/grpc-gateway-upgrade` --- ### 📝 Commits (1) - [`da24961`](https://github.com/juanfont/headscale/commit/da24961167548d981bf907280ec00627e1d27fd9) hscontrol: remove go-grpc-middleware v1 dependency ### 📊 Changes **5 files changed** (+10 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `flake.nix` (+1 -1) 📝 `go.mod` (+0 -1) 📝 `go.sum` (+0 -65) 📝 `hscontrol/app.go` (+4 -7) 📝 `proto/buf.lock` (+5 -2) </details> ### 📄 Description Replace grpc-ecosystem/go-grpc-middleware v1.4.0 with gRPC's built-in interceptor chaining. The v1 library's ChainUnaryServer function is deprecated as gRPC now provides native chaining via grpc.ChainUnaryInterceptor. Also update protobuf dependencies in buf.lock: - googleapis: 62f35d8a -> 61b203b9 - grpc-gateway: bc28b723 -> 4c5ba75c --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:18:57 +01:00
adam closed this issue 2025-12-29 04:18:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2783
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?