starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2639] [MERGED] state: introduction #2775

New Issue
Closed
opened 2025-12-29 04:18:56 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:18:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2639
Author: @kradalby
Created: 6/1/2025
Status: ✅ Merged
Merged: 6/24/2025
Merged by: @kradalby

Base: main ← Head: kradalby/state-experiment

📝 Commits (1)

📊 Changes

17 files changed (+1379 additions, -1056 deletions)

View changed files

📝 hscontrol/app.go (+98 -257)
📝 hscontrol/auth.go (+40 -98)
📝 hscontrol/db/node.go (+3 -0)
📝 hscontrol/db/users.go (+6 -7)
📝 hscontrol/db/users_test.go (+20 -8)
📝 hscontrol/debug.go (+33 -19)
📝 hscontrol/grpcv1.go (+116 -138)
📝 hscontrol/handlers.go (+2 -2)
📝 hscontrol/mapper/mapper.go (+24 -40)
📝 hscontrol/mapper/mapper_test.go (+72 -353)
📝 hscontrol/mapper/tail.go (+9 -5)
📝 hscontrol/noise.go (+1 -1)
📝 hscontrol/oidc.go (+59 -42)
📝 hscontrol/poll.go (+39 -66)
➕ hscontrol/state/state.go (+812 -0)
📝 hscontrol/types/preauth_key.go (+27 -0)
📝 hscontrol/types/preauth_key_test.go (+18 -20)

📄 Description

this commit moves all of the read and write logic, and all different parts
of headscale that manages some sort of persistent and in memory state into
a separate package.

The goal of this is to clearly define the boundry between parts of the app
which accesses and modifies data, and where it happens. Previously, different
state (routes, policy, db and so on) was used directly, and sometime passed to
functions as pointers.

Now all access has to go through state. In the initial implementation,
most of the same functions exists and have just been moved. In the future
centralising this will allow us to optimise bottle necks with the database
(in memory state) and make the different parts talking to eachother do so
in the same way across headscale components.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2639 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 6/1/2025 **Status:** ✅ Merged **Merged:** 6/24/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/state-experiment` --- ### 📝 Commits (1) - [`750f90b`](https://github.com/juanfont/headscale/commit/750f90b81a503095237912af28f83f6b1cdee965) state: introduce state ### 📊 Changes **17 files changed** (+1379 additions, -1056 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/app.go` (+98 -257) 📝 `hscontrol/auth.go` (+40 -98) 📝 `hscontrol/db/node.go` (+3 -0) 📝 `hscontrol/db/users.go` (+6 -7) 📝 `hscontrol/db/users_test.go` (+20 -8) 📝 `hscontrol/debug.go` (+33 -19) 📝 `hscontrol/grpcv1.go` (+116 -138) 📝 `hscontrol/handlers.go` (+2 -2) 📝 `hscontrol/mapper/mapper.go` (+24 -40) 📝 `hscontrol/mapper/mapper_test.go` (+72 -353) 📝 `hscontrol/mapper/tail.go` (+9 -5) 📝 `hscontrol/noise.go` (+1 -1) 📝 `hscontrol/oidc.go` (+59 -42) 📝 `hscontrol/poll.go` (+39 -66) ➕ `hscontrol/state/state.go` (+812 -0) 📝 `hscontrol/types/preauth_key.go` (+27 -0) 📝 `hscontrol/types/preauth_key_test.go` (+18 -20) </details> ### 📄 Description this commit moves all of the read and write logic, and all different parts of headscale that manages some sort of persistent and in memory state into a separate package. The goal of this is to clearly define the boundry between parts of the app which accesses and modifies data, and where it happens. Previously, different state (routes, policy, db and so on) was used directly, and sometime passed to functions as pointers. Now all access has to go through state. In the initial implementation, most of the same functions exists and have just been moved. In the future centralising this will allow us to optimise bottle necks with the database (in memory state) and make the different parts talking to eachother do so in the same way across headscale components. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:18:56 +01:00
adam closed this issue 2025-12-29 04:18:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2775
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?