starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2635] [MERGED] Ensure that a username starts with a letter #2772

New Issue
Closed
opened 2025-12-29 04:18:55 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:18:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2635
Author: @nblock
Created: 5/29/2025
Status: ✅ Merged
Merged: 6/24/2025
Merged by: @kradalby

Base: main ← Head: start-with-letter

📝 Commits (1)

  • 7e14d4b Ensure that a username starts with a letter

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 hscontrol/util/dns.go (+3 -3)

📄 Description

The docstring for ValidateUsername() states:

It must be at least 2 characters long, start with a letter, and
contain only letters, numbers, hyphens, dots, and underscores.

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2635 **Author:** [@nblock](https://github.com/nblock) **Created:** 5/29/2025 **Status:** ✅ Merged **Merged:** 6/24/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `start-with-letter` --- ### 📝 Commits (1) - [`7e14d4b`](https://github.com/juanfont/headscale/commit/7e14d4b4e56fb212ef0cba9e8ac53bc429b31df4) Ensure that a username starts with a letter ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/util/dns.go` (+3 -3) </details> ### 📄 Description The docstring for `ValidateUsername()` states: > It must be at least 2 characters long, start with a letter, and > contain only letters, numbers, hyphens, dots, and underscores. - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [x] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [ ] updated documentation if needed - [ ] updated CHANGELOG.md --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:18:55 +01:00
adam closed this issue 2025-12-29 04:18:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2772
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?