mirror of
https://github.com/juanfont/headscale.git
synced 2026-01-11 20:00:28 +01:00
[Not bug, but Enhancement]Rename Machine won't change the name's record in [nodes ls] #276
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @1itt1eB0y on GitHub (Jun 16, 2022).
I changed my kali(ID:2) to pi.
It says success and it was changed in my clients.
But it is still the old name in headscale's command output.
@1itt1eB0y commented on GitHub (Jun 16, 2022):
I noticed there is a
given_namein DB, so why not make it list in the output of cli?@huskyii commented on GitHub (Jul 22, 2022):
Observe same issue, it's pretty confusing, I'd suggest add a
Hostnamecolumn in thenodes lsoutputs.And the mapping is:
machine.Name -> Hostname
machine.GivenName -> Name
I've implemented this enhancement, @kradalby if you think this is ok, I can open a PR
@kradalby commented on GitHub (Jul 22, 2022):
Yes please