starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2576] [MERGED] policy/v2: validate that no undefined group or tag is used #2741

New Issue
Closed
opened 2025-12-29 04:18:43 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:18:43 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2576
Author: @kradalby
Created: 5/9/2025
Status: ✅ Merged
Merged: 5/9/2025
Merged by: @kradalby

Base: main ← Head: kradalby/pol-group-tag-check

📝 Commits (3)

  • 37f3397 policy/v2: allow Username as ssh source
  • c8b57c4 policy/v2: validate that no undefined group or tag is used
  • e68ffb8 policy: fixup tests which violated tag constraing

📊 Changes

3 files changed (+333 additions, -27 deletions)

View changed files

📝 hscontrol/policy/policy_test.go (+30 -26)
📝 hscontrol/policy/v2/types.go (+108 -1)
📝 hscontrol/policy/v2/types_test.go (+195 -0)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2576 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 5/9/2025 **Status:** ✅ Merged **Merged:** 5/9/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/pol-group-tag-check` --- ### 📝 Commits (3) - [`37f3397`](https://github.com/juanfont/headscale/commit/37f33975d47eacb90f29fa6db731313fa9f1d5e9) policy/v2: allow Username as ssh source - [`c8b57c4`](https://github.com/juanfont/headscale/commit/c8b57c441a926f1f1576c9fd1b1859b920f9ec15) policy/v2: validate that no undefined group or tag is used - [`e68ffb8`](https://github.com/juanfont/headscale/commit/e68ffb86c99ebdaf91221faf2b71a896b5633213) policy: fixup tests which violated tag constraing ### 📊 Changes **3 files changed** (+333 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/policy/policy_test.go` (+30 -26) 📝 `hscontrol/policy/v2/types.go` (+108 -1) 📝 `hscontrol/policy/v2/types_test.go` (+195 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:18:43 +01:00
adam closed this issue 2025-12-29 04:18:43 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2741
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?