starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2555] [MERGED] Make more granular SSH tests for both Policies #2729

New Issue
Closed
opened 2025-12-29 04:18:40 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:18:40 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2555
Author: @kradalby
Created: 5/2/2025
Status: ✅ Merged
Merged: 5/4/2025
Merged by: @kradalby

Base: main ← Head: kradalby/sshv2-tests

📝 Commits (10+)

  • 563c6a5 policy/v1: dont consider empty if ssh has rules
  • d594a7d policy/v2: replace time.Duration with model.Duration
  • b355ef9 policy/v2: add autogroup and ssh validation
  • 5347a39 policy/v2: replace time.Duration with model.Duration
  • c5ea2d4 policy: replace old ssh tests with more granular test
  • d3bc76a policy: skip v1 tests expected to fail (missing error handling)
  • eb05368 policy: skip v1 group tests, old bugs wont be fixed
  • 45bb3bc integration: user valid policy for ssh
  • e74df22 Changelog, add ssh section
  • 20ff0b0 nix update

📊 Changes

8 files changed (+599 additions, -220 deletions)

View changed files

📝 CHANGELOG.md (+14 -2)
📝 flake.lock (+3 -3)
📝 hscontrol/policy/policy_test.go (+406 -0)
📝 hscontrol/policy/v1/acls_test.go (+0 -194)
📝 hscontrol/policy/v1/acls_types.go (+1 -1)
📝 hscontrol/policy/v2/filter.go (+1 -1)
📝 hscontrol/policy/v2/types.go (+170 -15)
📝 integration/ssh_test.go (+4 -4)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2555 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 5/2/2025 **Status:** ✅ Merged **Merged:** 5/4/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/sshv2-tests` --- ### 📝 Commits (10+) - [`563c6a5`](https://github.com/juanfont/headscale/commit/563c6a5a5effade1e1b0c195cd3153298fef2aa2) policy/v1: dont consider empty if ssh has rules - [`d594a7d`](https://github.com/juanfont/headscale/commit/d594a7d3cefeee97aa04f0ecada367c76a3b25c8) policy/v2: replace time.Duration with model.Duration - [`b355ef9`](https://github.com/juanfont/headscale/commit/b355ef916255c09f66de51a41075ebfa21b631ce) policy/v2: add autogroup and ssh validation - [`5347a39`](https://github.com/juanfont/headscale/commit/5347a39cc1e446a57b1a75fb78a8abaa7dba2f72) policy/v2: replace time.Duration with model.Duration - [`c5ea2d4`](https://github.com/juanfont/headscale/commit/c5ea2d4aae4ed397a5ef63568172e763954693bb) policy: replace old ssh tests with more granular test - [`d3bc76a`](https://github.com/juanfont/headscale/commit/d3bc76a49a4d2c3c22eb672b5d3e7b7b6a561a19) policy: skip v1 tests expected to fail (missing error handling) - [`eb05368`](https://github.com/juanfont/headscale/commit/eb05368dd55910742b6ba7279fb05cd3172446e9) policy: skip v1 group tests, old bugs wont be fixed - [`45bb3bc`](https://github.com/juanfont/headscale/commit/45bb3bcf5ca784b9be8e826cacfe3bc3ad165fcf) integration: user valid policy for ssh - [`e74df22`](https://github.com/juanfont/headscale/commit/e74df22b8b75c6f24343a153534535738fe7f3f1) Changelog, add ssh section - [`20ff0b0`](https://github.com/juanfont/headscale/commit/20ff0b0e9fe3df08ea59313b8121374b2fc91b42) nix update ### 📊 Changes **8 files changed** (+599 additions, -220 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+14 -2) 📝 `flake.lock` (+3 -3) 📝 `hscontrol/policy/policy_test.go` (+406 -0) 📝 `hscontrol/policy/v1/acls_test.go` (+0 -194) 📝 `hscontrol/policy/v1/acls_types.go` (+1 -1) 📝 `hscontrol/policy/v2/filter.go` (+1 -1) 📝 `hscontrol/policy/v2/types.go` (+170 -15) 📝 `integration/ssh_test.go` (+4 -4) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:18:40 +01:00
adam closed this issue 2025-12-29 04:18:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2729
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?