starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2550] [MERGED] auth: ensure that routes are autoapproved when the node is stored #2723

New Issue
Closed
opened 2025-12-29 03:22:29 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2550
Author: @kradalby
Created: 4/30/2025
Status: ✅ Merged
Merged: 5/1/2025
Merged by: @kradalby

Base: main ← Head: kradalby/web-auth-no-autoappr

📝 Commits (2)

  • 9050eb4 integration: ensure route is set before node joins, reproduce
  • 25027b2 auth: ensure that routes are autoapproved when the node is stored

📊 Changes

4 files changed (+57 additions, -14 deletions)

View changed files

📝 hscontrol/auth.go (+17 -7)
📝 hscontrol/grpcv1.go (+18 -1)
📝 hscontrol/oidc.go (+17 -1)
📝 integration/route_test.go (+5 -5)

📄 Description

Fixes #2547

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2550 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 4/30/2025 **Status:** ✅ Merged **Merged:** 5/1/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/web-auth-no-autoappr` --- ### 📝 Commits (2) - [`9050eb4`](https://github.com/juanfont/headscale/commit/9050eb466b73d6b1e7c7daff74b5826b31d75a10) integration: ensure route is set before node joins, reproduce - [`25027b2`](https://github.com/juanfont/headscale/commit/25027b29f0adadc52ae50e61888967e414fa157e) auth: ensure that routes are autoapproved when the node is stored ### 📊 Changes **4 files changed** (+57 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/auth.go` (+17 -7) 📝 `hscontrol/grpcv1.go` (+18 -1) 📝 `hscontrol/oidc.go` (+17 -1) 📝 `integration/route_test.go` (+5 -5) </details> ### 📄 Description Fixes #2547 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:29 +01:00
adam closed this issue 2025-12-29 03:22:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2723
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?