starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2549] [MERGED] integration: remove failing resolvconf tests #2722

New Issue
Closed
opened 2025-12-29 03:22:29 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2549
Author: @kradalby
Created: 4/29/2025
Status: ✅ Merged
Merged: 4/30/2025
Merged by: @kradalby

Base: main ← Head: kradalby/remove-valid-resolvconf

📝 Commits (1)

  • 881b8dc integration: remove failing resolvconf tests

📊 Changes

2 files changed (+0 additions, -164 deletions)

View changed files

📝 .github/workflows/test-integration.yaml (+0 -1)
📝 integration/dns_test.go (+0 -163)

📄 Description

Remove TestValidateResolvConf

These tests has been failing for a long time, docker has changed something and it feels like it will not provide us enough value compared to our effort of playing cat and mouse with Docker/github actions/other envs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2549 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 4/29/2025 **Status:** ✅ Merged **Merged:** 4/30/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/remove-valid-resolvconf` --- ### 📝 Commits (1) - [`881b8dc`](https://github.com/juanfont/headscale/commit/881b8dcb901e8bd45f329a404986ea4534078396) integration: remove failing resolvconf tests ### 📊 Changes **2 files changed** (+0 additions, -164 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration.yaml` (+0 -1) 📝 `integration/dns_test.go` (+0 -163) </details> ### 📄 Description Remove `TestValidateResolvConf` These tests has been failing for a long time, docker has changed something and it feels like it will not provide us enough value compared to our effort of playing cat and mouse with Docker/github actions/other envs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:29 +01:00
adam closed this issue 2025-12-29 03:22:29 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2722
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?