starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2545] [MERGED] oidc: try to get username from userinfo #2719

New Issue
Closed
opened 2025-12-29 03:22:29 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2545
Author: @kradalby
Created: 4/23/2025
Status: ✅ Merged
Merged: 4/30/2025
Merged by: @kradalby

Base: main ← Head: kradalby/2516-oidc-userinfo

📝 Commits (2)

📊 Changes

3 files changed (+36 additions, -8 deletions)

View changed files

📝 CHANGELOG.md (+2 -0)
📝 hscontrol/oidc.go (+22 -7)
📝 hscontrol/types/users.go (+12 -1)

📄 Description

This builds on #2493 to get more useful information from userinfo if it is not set in the claim.

@benley would be interested to have your review on this pr.

Fixes #2516

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2545 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 4/23/2025 **Status:** ✅ Merged **Merged:** 4/30/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/2516-oidc-userinfo` --- ### 📝 Commits (2) - [`a2527f9`](https://github.com/juanfont/headscale/commit/a2527f9d068decbf5bfd8db16aeaa1c046aae494) oidc: try to get username from userinfo - [`c42eb70`](https://github.com/juanfont/headscale/commit/c42eb705976d77cdda4cce8322b9c949dc0e2a0b) changelog ### 📊 Changes **3 files changed** (+36 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -0) 📝 `hscontrol/oidc.go` (+22 -7) 📝 `hscontrol/types/users.go` (+12 -1) </details> ### 📄 Description This builds on #2493 to get more useful information from userinfo if it is not set in the claim. @benley would be interested to have your review on this pr. Fixes #2516 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:29 +01:00
adam closed this issue 2025-12-29 03:22:29 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2719
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?