starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-12 04:10:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2532] [MERGED] more wait, more retry #2709

New Issue
Closed
opened 2025-12-29 03:22:26 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2532
Author: @kradalby
Created: 4/16/2025
Status: ✅ Merged
Merged: 4/16/2025
Merged by: @kradalby

Base: main ← Head: kradalby/retry-delays

📝 Commits (1)

📊 Changes

2 files changed (+22 additions, -2 deletions)

View changed files

📝 .github/workflows/test-integration-policyv2.yaml (+11 -1)
📝 .github/workflows/test-integration.yaml (+11 -1)

📄 Description

From my lengthy comment for rational:

    ⋮ 130│          # Our integration tests are started like a thundering herd, often
    ⋮ 131│          # hitting limits of the various external repositories we depend on
    ⋮ 132│          # like docker hub. This will retry jobs every 5 min, 10 times,
    ⋮ 133│          # hopefully letting us avoid manual intervention and restarting jobs.
    ⋮ 134│          # One could of course argue that we should invest in trying to avoid
    ⋮ 135│          # this, but currently it seems like a larger investment to be cleverer
    ⋮ 136│          # about this.
    ⋮ 137│          # Some of the jobs might still require manual restart as they are really
    ⋮ 138│          # slow and this will cause them to eventually be killed by Github actions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2532 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 4/16/2025 **Status:** ✅ Merged **Merged:** 4/16/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/retry-delays` --- ### 📝 Commits (1) - [`64f860a`](https://github.com/juanfont/headscale/commit/64f860a564def3007848fc68d2c296dc370aad53) more wait, more retry ### 📊 Changes **2 files changed** (+22 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration-policyv2.yaml` (+11 -1) 📝 `.github/workflows/test-integration.yaml` (+11 -1) </details> ### 📄 Description From my lengthy comment for rational: ``` ⋮ 130│ # Our integration tests are started like a thundering herd, often ⋮ 131│ # hitting limits of the various external repositories we depend on ⋮ 132│ # like docker hub. This will retry jobs every 5 min, 10 times, ⋮ 133│ # hopefully letting us avoid manual intervention and restarting jobs. ⋮ 134│ # One could of course argue that we should invest in trying to avoid ⋮ 135│ # this, but currently it seems like a larger investment to be cleverer ⋮ 136│ # about this. ⋮ 137│ # Some of the jobs might still require manual restart as they are really ⋮ 138│ # slow and this will cause them to eventually be killed by Github actions. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:26 +01:00
adam closed this issue 2025-12-29 03:22:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2709
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?