starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2495] [MERGED] allow users to be defined with @ in v1 #2692

New Issue
Closed
opened 2025-12-29 03:22:22 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2495
Author: @kradalby
Created: 3/21/2025
Status: ✅ Merged
Merged: 3/30/2025
Merged by: @kradalby

Base: main ← Head: kradalby/v2-users-in-v1

📝 Commits (6)

  • 639c5ef allow users to be defined with @ in v1
  • 0cd1e31 remove integration test rewrite hack
  • 868323f remove test rewrite hack
  • 95bd128 add @ to integration tests
  • 407e076 a bit to agressive removeals
  • bfe7546 fix last test

📊 Changes

12 files changed (+76 additions, -150 deletions)

View changed files

📝 hscontrol/db/node_test.go (+4 -9)
📝 hscontrol/policy/policy_test.go (+1 -18)
📝 hscontrol/policy/v1/acls.go (+4 -0)
📝 hscontrol/policy/v1/acls_test.go (+10 -0)
📝 hscontrol/util/dns.go (+2 -2)
📝 hscontrol/util/string_test.go (+1 -1)
📝 integration/acl_test.go (+34 -37)
📝 integration/cli_test.go (+9 -20)
📝 integration/general_test.go (+1 -1)
📝 integration/hsic/hsic.go (+0 -52)
📝 integration/route_test.go (+3 -3)
📝 integration/ssh_test.go (+7 -7)

📄 Description

Make it so we dont have to write two docs, remove rewrite hack for integration test.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2495 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 3/21/2025 **Status:** ✅ Merged **Merged:** 3/30/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/v2-users-in-v1` --- ### 📝 Commits (6) - [`639c5ef`](https://github.com/juanfont/headscale/commit/639c5ef150b7ddce24d25349801049ae55fc5ac2) allow users to be defined with @ in v1 - [`0cd1e31`](https://github.com/juanfont/headscale/commit/0cd1e31d617aac20a7d4b753c477ee66f28f0a38) remove integration test rewrite hack - [`868323f`](https://github.com/juanfont/headscale/commit/868323f6990f7c1394b0e8779bcdeb5b97edef1b) remove test rewrite hack - [`95bd128`](https://github.com/juanfont/headscale/commit/95bd128f8620d4006ea1e0a8b771fd6ddaf6e101) add @ to integration tests - [`407e076`](https://github.com/juanfont/headscale/commit/407e076ea6dee46c1c67576780f4f71b68a96552) a bit to agressive removeals - [`bfe7546`](https://github.com/juanfont/headscale/commit/bfe7546b72edd9bca24bfe9e17db45b2f70cd271) fix last test ### 📊 Changes **12 files changed** (+76 additions, -150 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/db/node_test.go` (+4 -9) 📝 `hscontrol/policy/policy_test.go` (+1 -18) 📝 `hscontrol/policy/v1/acls.go` (+4 -0) 📝 `hscontrol/policy/v1/acls_test.go` (+10 -0) 📝 `hscontrol/util/dns.go` (+2 -2) 📝 `hscontrol/util/string_test.go` (+1 -1) 📝 `integration/acl_test.go` (+34 -37) 📝 `integration/cli_test.go` (+9 -20) 📝 `integration/general_test.go` (+1 -1) 📝 `integration/hsic/hsic.go` (+0 -52) 📝 `integration/route_test.go` (+3 -3) 📝 `integration/ssh_test.go` (+7 -7) </details> ### 📄 Description Make it so we dont have to write two docs, remove rewrite hack for integration test. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:22 +01:00
adam closed this issue 2025-12-29 03:22:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2692
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?