starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2445] [MERGED] fix double login URL with OIDC #2674

New Issue
Closed
opened 2025-12-29 03:22:18 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2445
Author: @kradalby
Created: 2/24/2025
Status: ✅ Merged
Merged: 2/25/2025
Merged by: @kradalby

Base: main ← Head: kradalby/double-redir

📝 Commits (4)

  • 3ea7ca3 factor out login url parser
  • b4e4b79 move to not trigger test gen checker
  • 2504f0d return regresp or err after waiting for registration
  • 13dd6f0 update changelog

📊 Changes

8 files changed (+151 additions, -26 deletions)

View changed files

📝 CHANGELOG.md (+3 -1)
📝 hscontrol/auth.go (+19 -13)
📝 hscontrol/db/node.go (+5 -0)
📝 hscontrol/grpcv1.go (+1 -1)
📝 hscontrol/types/common.go (+1 -1)
📝 hscontrol/util/util.go (+36 -1)
📝 hscontrol/util/util_test.go (+85 -0)
📝 integration/tsic/tsic.go (+1 -9)

📄 Description

Fixes #2441

what essentially happens is:
node tries to register, gets URL
node reopens the connection with a "followup url"
registration code sits in the followup and waits for the registration to complete
error goes here: it didnt return when the followup finished, it continued the code and sent a new registration url

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2445 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/24/2025 **Status:** ✅ Merged **Merged:** 2/25/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/double-redir` --- ### 📝 Commits (4) - [`3ea7ca3`](https://github.com/juanfont/headscale/commit/3ea7ca3709d3febc1dd07693174a4372869663eb) factor out login url parser - [`b4e4b79`](https://github.com/juanfont/headscale/commit/b4e4b79a716a91454b663a2073a0c4fb24b69e3a) move to not trigger test gen checker - [`2504f0d`](https://github.com/juanfont/headscale/commit/2504f0de4c22f934e2ec17e6ce5ba74475adf4a1) return regresp or err after waiting for registration - [`13dd6f0`](https://github.com/juanfont/headscale/commit/13dd6f05d6ac7e1af16f57e65b84db0219de4ae3) update changelog ### 📊 Changes **8 files changed** (+151 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -1) 📝 `hscontrol/auth.go` (+19 -13) 📝 `hscontrol/db/node.go` (+5 -0) 📝 `hscontrol/grpcv1.go` (+1 -1) 📝 `hscontrol/types/common.go` (+1 -1) 📝 `hscontrol/util/util.go` (+36 -1) 📝 `hscontrol/util/util_test.go` (+85 -0) 📝 `integration/tsic/tsic.go` (+1 -9) </details> ### 📄 Description Fixes #2441 what essentially happens is: node tries to register, gets URL node reopens the connection with a "followup url" registration code sits in the followup and waits for the registration to complete error goes here: it didnt return when the followup finished, it continued the code and sent a new registration url --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:18 +01:00
adam closed this issue 2025-12-29 03:22:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2674
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?