starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2410] [MERGED] use helper function for constructing state updates #2650

New Issue
Closed
opened 2025-12-29 03:22:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2410
Author: @kradalby
Created: 2/6/2025
Status: ✅ Merged
Merged: 2/7/2025
Merged by: @kradalby

Base: main ← Head: kradalby/update-helper

📝 Commits (1)

  • d85bd2f use helper function for constructing state updates

📊 Changes

9 files changed (+56 additions, -107 deletions)

View changed files

📝 hscontrol/app.go (+6 -14)
📝 hscontrol/auth.go (+4 -10)
📝 hscontrol/db/node.go (+3 -9)
📝 hscontrol/db/routes.go (+2 -5)
📝 hscontrol/grpcv1.go (+10 -38)
📝 hscontrol/notifier/notifier.go (+2 -8)
📝 hscontrol/oidc.go (+2 -2)
📝 hscontrol/poll.go (+4 -18)
📝 hscontrol/types/common.go (+23 -3)

📄 Description

This helps preventing messages being sent with the wrong update type and payload combination, and it is shorter/neater.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2410 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 2/6/2025 **Status:** ✅ Merged **Merged:** 2/7/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/update-helper` --- ### 📝 Commits (1) - [`d85bd2f`](https://github.com/juanfont/headscale/commit/d85bd2f9fa1af9cf16f6cd541a42671471a18092) use helper function for constructing state updates ### 📊 Changes **9 files changed** (+56 additions, -107 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/app.go` (+6 -14) 📝 `hscontrol/auth.go` (+4 -10) 📝 `hscontrol/db/node.go` (+3 -9) 📝 `hscontrol/db/routes.go` (+2 -5) 📝 `hscontrol/grpcv1.go` (+10 -38) 📝 `hscontrol/notifier/notifier.go` (+2 -8) 📝 `hscontrol/oidc.go` (+2 -2) 📝 `hscontrol/poll.go` (+4 -18) 📝 `hscontrol/types/common.go` (+23 -3) </details> ### 📄 Description This helps preventing messages being sent with the wrong update type and payload combination, and it is shorter/neater. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:12 +01:00
adam closed this issue 2025-12-29 03:22:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2650
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?