starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 03:40:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2367] [MERGED] fix postgres migration issue with 0.24 #2628

New Issue
Closed
opened 2025-12-29 03:22:06 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:06 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2367
Author: @kradalby
Created: 1/22/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @kradalby

Base: main ← Head: kradalby/2351-fix-postgres-migration

📝 Commits (3)

  • 727a631 fix postgres migration issue with 0.24
  • b7df105 add postgres migration test for 2351
  • 0c3efe9 update changelog

📊 Changes

5 files changed (+105 additions, -8 deletions)

View changed files

📝 CHANGELOG.md (+2 -0)
📝 hscontrol/db/db.go (+32 -0)
📝 hscontrol/db/db_test.go (+60 -1)
📝 hscontrol/db/suite_test.go (+11 -7)
➕ hscontrol/db/testdata/pre-24-postgresdb.pssql.dump (+0 -0)

📄 Description

Fixes #2351

This works, I have tests locally, but I need to have the database sanitised before I can upload it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2367 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 1/22/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/2351-fix-postgres-migration` --- ### 📝 Commits (3) - [`727a631`](https://github.com/juanfont/headscale/commit/727a6310f891e4ba9d033a6c943ef9841380be2e) fix postgres migration issue with 0.24 - [`b7df105`](https://github.com/juanfont/headscale/commit/b7df105ce7eae01b3c0626fab89129c15eca8e00) add postgres migration test for 2351 - [`0c3efe9`](https://github.com/juanfont/headscale/commit/0c3efe9475d8da0bc9a33f6d5d32645818e39acf) update changelog ### 📊 Changes **5 files changed** (+105 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -0) 📝 `hscontrol/db/db.go` (+32 -0) 📝 `hscontrol/db/db_test.go` (+60 -1) 📝 `hscontrol/db/suite_test.go` (+11 -7) ➕ `hscontrol/db/testdata/pre-24-postgresdb.pssql.dump` (+0 -0) </details> ### 📄 Description Fixes #2351 This works, I have tests locally, but I need to have the database sanitised before I can upload it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:06 +01:00
adam closed this issue 2025-12-29 03:22:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2628
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?