starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2348] [CLOSED] add TestOIDCReloginSameNode #2620

New Issue
Closed
opened 2025-12-29 03:22:05 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2348
Author: @kradalby
Created: 1/17/2025
Status: ❌ Closed

Base: main ← Head: kradalby/oidc-relog-test

📝 Commits (1)

  • 1d5c8e7 add TestOIDCReloginSameNode

📊 Changes

2 files changed (+279 additions, -0 deletions)

View changed files

📝 .github/workflows/test-integration.yaml (+1 -0)
📝 integration/auth_oidc_test.go (+278 -0)

📄 Description

Currently only broken test, this was more than anticipated and it starts with #2337

This PR aims to fix #2327, currently if user A logs in a node, it belongs to A. When A logs out and the same node is logged into as user B, it still belongs to A. Tailscale upstream creates a new node, the Node-User relation ship should be unique.

Fixes #2327

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2348 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 1/17/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `kradalby/oidc-relog-test` --- ### 📝 Commits (1) - [`1d5c8e7`](https://github.com/juanfont/headscale/commit/1d5c8e7a2bbc9114a4528a84956ffa86c4d69d02) add TestOIDCReloginSameNode ### 📊 Changes **2 files changed** (+279 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration.yaml` (+1 -0) 📝 `integration/auth_oidc_test.go` (+278 -0) </details> ### 📄 Description Currently only broken test, this was more than anticipated and it starts with #2337 This PR aims to fix #2327, currently if user A logs in a node, it belongs to A. When A logs out and the same node is logged into as user B, it still belongs to A. Tailscale upstream creates a new node, the Node-User relation ship should be unique. Fixes #2327 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:05 +01:00
adam closed this issue 2025-12-29 03:22:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2620
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?