starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2340] [MERGED] allow @ and Log if OIDC username is not consider valid #2611

New Issue
Closed
opened 2025-12-29 03:22:02 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:22:02 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2340
Author: @kradalby
Created: 1/10/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @kradalby

Base: main ← Head: kradalby/2333-log-username-not-valid

📝 Commits (2)

  • 973bbbb Log if OIDC username is not consider valid
  • bf2071c split dns and username validator

📊 Changes

2 files changed (+38 additions, -4 deletions)

View changed files

📝 hscontrol/types/users.go (+4 -1)
📝 hscontrol/util/dns.go (+34 -3)

📄 Description

Updates #2333

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2340 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/2333-log-username-not-valid` --- ### 📝 Commits (2) - [`973bbbb`](https://github.com/juanfont/headscale/commit/973bbbb1f2aafd31c3c6805f7bae8b4b41352b3c) Log if OIDC username is not consider valid - [`bf2071c`](https://github.com/juanfont/headscale/commit/bf2071c629788c6961aeee470cef4f3873367c5e) split dns and username validator ### 📊 Changes **2 files changed** (+38 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/types/users.go` (+4 -1) 📝 `hscontrol/util/dns.go` (+34 -3) </details> ### 📄 Description Updates #2333 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:22:02 +01:00
adam closed this issue 2025-12-29 03:22:02 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2611
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?