starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

bug in function excludeCorrectlyTaggedNodes() #261

New Issue
Closed
opened 2025-12-29 01:25:13 +01:00 by adam · 2 comments
adam commented 2025-12-29 01:25:13 +01:00
Owner
Copy Link

Originally created by @awsong on GitHub (Apr 28, 2022).

In function excludeCorrectlyTaggedNodes() when matching tags with tagOwners:
e80954b6c8/acls.go (L314)
The above line missing the condition when tagOwners are groups.
Adding two lines here could fix this problem
owners, _ := expandTagOwners(aclPolicy, namespace, true)
ns = append(owners, namespace)
But the third parameter (true/false) needs to be filled correctly, which I'm not sure how could be elegantly done.

Originally created by @awsong on GitHub (Apr 28, 2022). In function excludeCorrectlyTaggedNodes() when matching tags with tagOwners: https://github.com/juanfont/headscale/blob/e80954b6c8f97f19ca881ab1c3bf5d7d2428d74c/acls.go#L314 The above line missing the condition when tagOwners are groups. Adding two lines here could fix this problem `owners, _ := expandTagOwners(aclPolicy, namespace, true)` `ns = append(owners, namespace)` But the third parameter (true/false) needs to be filled correctly, which I'm not sure how could be elegantly done.
adam closed this issue 2025-12-29 01:25:14 +01:00
adam commented 2025-12-29 01:25:14 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Jun 12, 2022):

We will be grateful for a PR to solve this issue :)

@restanrm, does this look right to you? Maybe this is already fixed?

@kradalby commented on GitHub (Jun 12, 2022): We will be grateful for a PR to solve this issue :) @restanrm, does this look right to you? Maybe this is already fixed?
adam commented 2025-12-29 01:25:15 +01:00
Author
Owner
Copy Link

@restanrm commented on GitHub (Jun 15, 2022):

I'll check this as soon as I found some time to do it.

@restanrm commented on GitHub (Jun 15, 2022): I'll check this as soon as I found some time to do it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#261
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?