starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 04:40:29 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2297] [MERGED] fix issue where some oidc claim bools are sent as string #2591

New Issue
Closed
opened 2025-12-29 03:21:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2297
Author: @kradalby
Created: 12/15/2024
Status: ✅ Merged
Merged: 12/16/2024
Merged by: @kradalby

Base: main ← Head: kradalby/unmarshal-broken-bool

📝 Commits (1)

  • f541003 fix issue where some oidc claim bools are sent as string

📊 Changes

2 files changed (+114 additions, -6 deletions)

View changed files

📝 hscontrol/types/users.go (+39 -6)
➕ hscontrol/types/users_test.go (+75 -0)

📄 Description

Jumpcloud send invalid json, so we need to handle it.

Fixes #2293

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2297 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 12/15/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/unmarshal-broken-bool` --- ### 📝 Commits (1) - [`f541003`](https://github.com/juanfont/headscale/commit/f5410036ed3b70beb1c2eff9893294ef6c267b9d) fix issue where some oidc claim bools are sent as string ### 📊 Changes **2 files changed** (+114 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `hscontrol/types/users.go` (+39 -6) ➕ `hscontrol/types/users_test.go` (+75 -0) </details> ### 📄 Description Jumpcloud send invalid json, so we need to handle it. Fixes #2293 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:57 +01:00
adam closed this issue 2025-12-29 03:21:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2591
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?