starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2279] [MERGED] Remove use_username_in_magic_dns option #2582

New Issue
Closed
opened 2025-12-29 03:21:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2279
Author: @nblock
Created: 12/11/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @nblock

Base: main ← Head: usermagicdns

📝 Commits (1)

  • 0acd0b2 Remove use_username_in_magic_dns option

📊 Changes

7 files changed (+5 additions, -21 deletions)

View changed files

📝 CHANGELOG.md (+1 -1)
📝 config-example.yaml (+0 -9)
📝 hscontrol/types/config.go (+4 -5)
📝 hscontrol/types/testdata/base-domain-in-server-url.yaml (+0 -1)
📝 hscontrol/types/testdata/base-domain-not-in-server-url.yaml (+0 -1)
📝 hscontrol/types/testdata/dns_full.yaml (+0 -2)
📝 hscontrol/types/testdata/dns_full_no_magic.yaml (+0 -2)

📄 Description

Upgrade the use of dns.use_username_in_magic_dns or dns_config.use_username_in_magic_dns to a fatal error and remove the option from the example configuration and integration tests.

Fixes: #2219

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2279 **Author:** [@nblock](https://github.com/nblock) **Created:** 12/11/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@nblock](https://github.com/nblock) **Base:** `main` ← **Head:** `usermagicdns` --- ### 📝 Commits (1) - [`0acd0b2`](https://github.com/juanfont/headscale/commit/0acd0b2e9ba33bbc9a42df043b7348b6324bd012) Remove use_username_in_magic_dns option ### 📊 Changes **7 files changed** (+5 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -1) 📝 `config-example.yaml` (+0 -9) 📝 `hscontrol/types/config.go` (+4 -5) 📝 `hscontrol/types/testdata/base-domain-in-server-url.yaml` (+0 -1) 📝 `hscontrol/types/testdata/base-domain-not-in-server-url.yaml` (+0 -1) 📝 `hscontrol/types/testdata/dns_full.yaml` (+0 -2) 📝 `hscontrol/types/testdata/dns_full_no_magic.yaml` (+0 -2) </details> ### 📄 Description Upgrade the use of `dns.use_username_in_magic_dns` or `dns_config.use_username_in_magic_dns` to a fatal error and remove the option from the example configuration and integration tests. Fixes: #2219 - [x] have read the [CONTRIBUTING.md](./CONTRIBUTING.md) file - [ ] raised a GitHub issue or discussed it on the projects chat beforehand - [ ] added unit tests - [ ] added integration tests - [x] updated documentation if needed - [x] updated CHANGELOG.md --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:54 +01:00
adam closed this issue 2025-12-29 03:21:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2582
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?