starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 11:50:30 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2273] [MERGED] fix docker network caps #2581

New Issue
Closed
opened 2025-12-29 03:21:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2273
Author: @kradalby
Created: 12/9/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @kradalby

Base: main ← Head: kradalby/december-gh-action-broken

📝 Commits (4)

  • e74ec0d upgrade dockertest
  • 5cd914f update docker network caps to adhere to modern docker
  • 50de3ed add additional debug steps and comments to github action
  • b63ec7d check tsic for panics on shutdown

📊 Changes

8 files changed (+81 additions, -42 deletions)

View changed files

📝 .github/workflows/test-integration.yaml (+26 -0)
📝 flake.nix (+2 -2)
📝 go.mod (+8 -7)
📝 go.sum (+18 -16)
📝 integration/dockertestutil/config.go (+8 -4)
📝 integration/scenario.go (+11 -1)
📝 integration/tailscale.go (+1 -1)
📝 integration/tsic/tsic.go (+7 -11)

📄 Description

Its December, all integration tests requiring networking seem to have broken...

Docker releases a patch release which changed the required permissions to be able to do tun devices in containers, this caused all containers to fail in tests causing us to fail all tests. This fixes it, and adds some tools for debugging in the future.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2273 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 12/9/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/december-gh-action-broken` --- ### 📝 Commits (4) - [`e74ec0d`](https://github.com/juanfont/headscale/commit/e74ec0d909e7c28a3b3a6e224043d9b1288353e3) upgrade dockertest - [`5cd914f`](https://github.com/juanfont/headscale/commit/5cd914f11d6038cad11d0f57af9d4087e031a6f4) update docker network caps to adhere to modern docker - [`50de3ed`](https://github.com/juanfont/headscale/commit/50de3ed19e4697d60033504fa53341d1d0bf597a) add additional debug steps and comments to github action - [`b63ec7d`](https://github.com/juanfont/headscale/commit/b63ec7dcc4a4909eb76181e98181a64b575771df) check tsic for panics on shutdown ### 📊 Changes **8 files changed** (+81 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test-integration.yaml` (+26 -0) 📝 `flake.nix` (+2 -2) 📝 `go.mod` (+8 -7) 📝 `go.sum` (+18 -16) 📝 `integration/dockertestutil/config.go` (+8 -4) 📝 `integration/scenario.go` (+11 -1) 📝 `integration/tailscale.go` (+1 -1) 📝 `integration/tsic/tsic.go` (+7 -11) </details> ### 📄 Description Its December, all integration tests requiring networking seem to have broken... Docker releases a patch release which changed the required permissions to be able to do tun devices in containers, this caused all containers to fail in tests causing us to fail all tests. This fixes it, and adds some tools for debugging in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:54 +01:00
adam closed this issue 2025-12-29 03:21:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2581
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?