starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #2261] [MERGED] restructure command/api to use stable IDs #2575

New Issue
Closed
opened 2025-12-29 03:21:53 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:21:53 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/2261
Author: @kradalby
Created: 11/29/2024
Status: ✅ Merged
Merged: 12/10/2024
Merged by: @kradalby

Base: main ← Head: kradalby/cli-ids

📝 Commits (10+)

  • 49658c7 add protobuf lsp
  • 4967d87 align protobuf format with lsp
  • 273483a update user api to use IDs over names
  • 15b26c9 format protobuf with new settings
  • eacb174 generate grpc for new user api
  • 57a0275 update changelog
  • c4b02da update code with new user api
  • 0be4c85 hsic: print failing command
  • a61ccc3 scenario: create users in alphabetical order
  • 39940e0 test new cli user behaviour

📊 Changes

29 files changed (+1947 additions, -3658 deletions)

View changed files

📝 CHANGELOG.md (+7 -2)
📝 Makefile (+8 -2)
📝 cmd/headscale/cli/users.go (+100 -30)
📝 flake.nix (+21 -4)
📝 gen/go/headscale/v1/apikey.pb.go (+37 -165)
📝 gen/go/headscale/v1/device.pb.go (+45 -201)
📝 gen/go/headscale/v1/headscale.pb.go (+319 -330)
📝 gen/go/headscale/v1/headscale.pb.gw.go (+465 -1136)
📝 gen/go/headscale/v1/headscale_grpc.pb.go (+0 -37)
📝 gen/go/headscale/v1/node.pb.go (+85 -381)
📝 gen/go/headscale/v1/policy.pb.go (+17 -75)
📝 gen/go/headscale/v1/preauthkey.pb.go (+29 -129)
📝 gen/go/headscale/v1/routes.pb.go (+45 -201)
📝 gen/go/headscale/v1/user.pb.go (+142 -369)
📝 gen/openapiv2/headscale/v1/headscale.swagger.json (+32 -44)
📝 hscontrol/grpcv1.go (+15 -17)
📝 hscontrol/types/users.go (+1 -1)
📝 integration/auth_oidc_test.go (+24 -24)
📝 integration/cli_test.go (+139 -11)
📝 integration/hsic/hsic.go (+2 -1)

...and 9 more files

📄 Description

fixes #2246

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/2261 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 11/29/2024 **Status:** ✅ Merged **Merged:** 12/10/2024 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `kradalby/cli-ids` --- ### 📝 Commits (10+) - [`49658c7`](https://github.com/juanfont/headscale/commit/49658c756cbfefb36fff9344d621afeadfc18706) add protobuf lsp - [`4967d87`](https://github.com/juanfont/headscale/commit/4967d87408cce169f014fe7c728a976b720e2901) align protobuf format with lsp - [`273483a`](https://github.com/juanfont/headscale/commit/273483a310c44d6049b6c8a87e5214c0c344ec1b) update user api to use IDs over names - [`15b26c9`](https://github.com/juanfont/headscale/commit/15b26c92314c5856f286a36fc91b07d8297d5abd) format protobuf with new settings - [`eacb174`](https://github.com/juanfont/headscale/commit/eacb17487330564a4f43cdcb56599d8bf749514f) generate grpc for new user api - [`57a0275`](https://github.com/juanfont/headscale/commit/57a0275cf486a27abf2aaaae1cf6a2c16bd406fc) update changelog - [`c4b02da`](https://github.com/juanfont/headscale/commit/c4b02daf2a0ebe0e29ec7d17cbdc839a36dd9a8b) update code with new user api - [`0be4c85`](https://github.com/juanfont/headscale/commit/0be4c859e97660911b1914dbfd81c3d0303a7c41) hsic: print failing command - [`a61ccc3`](https://github.com/juanfont/headscale/commit/a61ccc32cc4dce43a3ab07579709215a55514df0) scenario: create users in alphabetical order - [`39940e0`](https://github.com/juanfont/headscale/commit/39940e0d14161b3a24fa4a4f6c1cc83cff1ebe72) test new cli user behaviour ### 📊 Changes **29 files changed** (+1947 additions, -3658 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+7 -2) 📝 `Makefile` (+8 -2) 📝 `cmd/headscale/cli/users.go` (+100 -30) 📝 `flake.nix` (+21 -4) 📝 `gen/go/headscale/v1/apikey.pb.go` (+37 -165) 📝 `gen/go/headscale/v1/device.pb.go` (+45 -201) 📝 `gen/go/headscale/v1/headscale.pb.go` (+319 -330) 📝 `gen/go/headscale/v1/headscale.pb.gw.go` (+465 -1136) 📝 `gen/go/headscale/v1/headscale_grpc.pb.go` (+0 -37) 📝 `gen/go/headscale/v1/node.pb.go` (+85 -381) 📝 `gen/go/headscale/v1/policy.pb.go` (+17 -75) 📝 `gen/go/headscale/v1/preauthkey.pb.go` (+29 -129) 📝 `gen/go/headscale/v1/routes.pb.go` (+45 -201) 📝 `gen/go/headscale/v1/user.pb.go` (+142 -369) 📝 `gen/openapiv2/headscale/v1/headscale.swagger.json` (+32 -44) 📝 `hscontrol/grpcv1.go` (+15 -17) 📝 `hscontrol/types/users.go` (+1 -1) 📝 `integration/auth_oidc_test.go` (+24 -24) 📝 `integration/cli_test.go` (+139 -11) 📝 `integration/hsic/hsic.go` (+2 -1) _...and 9 more files_ </details> ### 📄 Description fixes #2246 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:21:53 +01:00
adam closed this issue 2025-12-29 03:21:53 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#2575
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?